chore: validate html descriptions, warn if invalid #196
Conversation
Signed-off-by: Stephen Rugh <rugh@adobe.com>
Signed-off-by: Stephen Rugh <rugh@adobe.com>
|
|
||
| Object.entries(fieldValidations).forEach(([field, validation]) => { | ||
| if (!validation.valid) { | ||
| context.logger.warn(`Validation failed for "${field}" field: ${validation.reason}`); |
There was a problem hiding this comment.
Is this log sufficient to inform the user? Hopefully users do not have to experience what I did - tracing backwards from malformed UX through EDS CDN, Azure, and finally realizing it is the data itself that is the problem.
@duynguyen let me know if there's a better way to alert users to bad data.
There was a problem hiding this comment.
the log message is good but it will potentially get lost among other logs.
IMO this should be tackled in a generic way, created #197
duynguyen
left a comment
duynguyen
left a comment
There was a problem hiding this comment.
changes looking good, can we have tests for the validation cases?
|
@duynguyen I will write tests and let you know once I've pushed. |
|
Why don't we use a library to sanitize the html instead, allowing only the tags that edge delivery supports, or none if the meta descriptions becomes the |
Signed-off-by: Stephen Rugh <rugh@adobe.com>
…ests Signed-off-by: Stephen Rugh <rugh@adobe.com>
sirugh
changed the title
3 participants
Closes #194
The reason this is happening is due to incorrect format in description data.
Technically this might happen for any user defined string which can be HTML.
This PR validates html for fields we are trying to template in that might be invalid.
DEBATE: