Fix/datetime#688
Merged
hmaier-fws merged 5 commits intodevelopfrom Feb 6, 2026
Merged
Conversation
Contributor
|
@jwaspin The precision values display properly on import, however there is an unexpected behavior that results in the date precision of a record, in active edit mode, being applied to records that are subsequently edited. Steps to recreate
Observed behavior
Expected behavior: |
…tern problems. 1. Moved setPrecisionBasedOnDate() from init() to didReceiveAttrs() — didReceiveAttrs is the Ember lifecycle hook that fires both on initial render AND whenever attrs update. This ensures precision is re-detected whenever the underlying record changes (component reuse scenario). 2. Added _suppressReformat flag — Wraps the setPrecisionBasedOnDate() call to prevent the selectedPrecisionChanged observer from reformatting date values during auto-detection. Since Ember observers fire synchronously during set(), the flag is true when the observer runs inside setPrecisionBasedOnDate(), and false afterward when the user explicitly changes precision from the dropdown.
Contributor
|
@hmaier-fws can we test this one |
Contributor
|
@dvonanderson looks like this works. I'll merge it into develop. closes #804 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.5.0-beta.28
Fixes issues when selecting precision for dates.
https://dev.mdeditor.org/