Conversation
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 26 linter errors (possibly disabled through directives):
|
1 similar comment
|
Tread carefully! This PR adds 26 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 26 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 26 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 26 linter errors (possibly disabled through directives):
|
* Remove quantcastId (#14045) * Remove quantcastIdSystem. * Remove references to quantcastId. --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * Remove quantcast bid adapter (#14054) * Remove quantcast bid adapter. * Update metadata. * Update modules.json * Add quantcastBidAdapter.json metadata file --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Patrick McCann <pmccann@cafemedia.com> * Delete modules/ringieraxelspringerBidAdapter.md * Delete test/spec/modules/ringieraxelspringerBidAdapter_spec.js * Delete modules/ringieraxelspringerBidAdapter.js * Delete metadata/modules/ringieraxelspringerBidAdapter.json * Remove ringieraxelspringerBidAdapter from overrides * Delete modules/dfpAdServerVideo.js * Delete modules/dfpAdpod.js * Delete modules/express.js * Prebid 11: remove PAAPI (#14432) * core: remove paapi support * PAAPI: remove paapi modules * Core: remove getBidToRender * Debugging: remove paapi support * Core: remove paapi events * PBS bid adapter: remove paapi support * VidazooUtils: remove paapi support * paapiTools: remove paapiTools * remove stray references to paapi methods * criteo bid adapter: remove paapi support * ix bid adapter: remove paapi support * logicAd bid adapter: remove paapi support * gumgum bid adapter: remove paapi support * ccx bid adapter: remove paapi support * Remove stray paapi tests * kargo bid adapter: remove paapi support * rtb house bid adapter: remove references to fledge in docs * onetag bid adapter: remove paapi support * medianet bid adapter: remove paapi support * lucead bid adapter: remove paapi support * openxBidAdapter: remove paapi support * optable bid adapter: remove paapi support * sharethrough bid adapter: remove paapi support * silverpush bid adapter: remove paapi support * sspBC bid adapter: remove paapi support * taboola bid adapter: remove paapi support * triplelift bid adapter: remove paapi support * ozone bid adapter: remove paapi support * lint * Delete modules/optableBidAdapter.js * Delete modules/optableBidAdapter.md * Delete test/spec/modules/optableBidAdapter_spec.js --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com> * Fix JSON formatting in quantcastBidAdapter.json * Core: default storageControl enforcement to strict (#14439) * Core: remove bidAccepted event emission (#14449) * 33across ID System: fix getId storage test stub isolation (#14457) * ShinezRtb Adapter: stabilize unique deal id timing test (#14446) * ShinezRtb Adapter: stabilize unique deal id test (#14458) * Core: remove null callback placeholders from storage manager reads/writes (#14461) * Prebid 11: remove adpod mediatype (#14451) * Core: remove dead adpod code paths from appnexus and mediafuse * Delete libraries/categoryTranslationMapping/index.js * Delete modules/categoryTranslation.js * Delete metadata/modules/categoryTranslation.json * Delete test/spec/modules/categoryTranslation_spec.js * Delete metadata/disclosures/prebid/categoryTranslation.json * Remove notifyTranslationModule and its hook registration Removed notifyTranslationModule function and its registration. * Remove brand category exclusion from payload Removed brand category uniqueness setting from payload. * Remove brand category uniqueness from payload Removed brand category uniqueness setting from payload. * Update appnexusBidAdapter_spec.js * Update mediafuseBidAdapter_spec.js * Update gamAdServerVideo.js * Update test_deps.js * Adapters: remove adpod media type handling across bidders (#14456) * Update aidemBidAdapter.js * Update aidemBidAdapter_spec.js * Prebid 11: 33across id system: make compatible with storage control change (#14462) * 33across ID Adapter: stabilize hashed email cleanup test * 33across Id System: gate HEM persistence on storeFpid * Update 33acrossIdSystem.js * remove unnecessary storageControl import * Prebid 11: turn off storageControl during testing (#14464) * Prebid 11: turn off storageControl during testing * remove unnecessary setConfig * Revert "Core: remove null callback placeholders from storage manager reads/wr…" (#14465) This reverts commit 1794187. * Prebid 11: remove superfluous addAdUnits and seat_non_bid event emission (#14466) * Core: remove addAdUnits event emission * Core: remove analytics subscriptions for addAdUnits * Core: remove addAdUnits event constant * Core: remove seatNonBid event constant * 33across Analytics Adapter: handle seatnonbid via pbsAnalytics (#14471) * Update 33acrossAnalyticsAdapter.js * Update 33acrossAnalyticsAdapter_spec.js * Prebid 11: remove deprecated DNT/DoNotTrack usage and force static dnt handling (#14448) * Fix data formatting in gmosspBidAdapter tests * Remove DNT signal handling from bid request Removed deprecated DNT signal handling from request. * Update video startdelay, skip, and bidfloor values * Update viewability checks to expect 0 instead of null * Update video startdelay and skip expectations * Update bidfloor and no bid response expectations * Remove dnt test case from rhythmoneBidAdapter_spec Removed test case for 'dnt is correctly set to 1' in rhythmoneBidAdapter_spec.js. * Update video startdelay and skip expectations * Update mileBidAdapter.ts * OpenX Adapter: restore getDNT usage for dnt field (#14472) * Core: restore getDNT payload mapping across adapters (#14474) * Update displayioBidAdapter.js * Update mediakeysBidAdapter.js * Update openxBidAdapter.js * Update yahooAdsBidAdapter.js * Update yieldmoBidAdapter.js * Update yieldmoBidAdapter_spec.js * Update enrichment.ts * Update openxBidAdapter.js * Update trafficgateBidAdapter_spec.js * Update trafficgateBidAdapter_spec.js * Update trafficgateBidAdapter_spec.js * Update trafficgateBidAdapter.js * Update trafficgateBidAdapter.js * Do not add DNT to adapters that don't care about it * linter --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * Prebid 11: add `adUnit.element` option (#14467) * Core: add elementSelector property of ad units * core: use getAdUnitElement * various adapters: use getAdUnitElement * various modules: use getAdUnitElement * various adapters: use getAdUnitElement * use .element, not .elementSelector * lint * fix secureCreatives tests * Update ixBidAdapter.js * Remove TODO note; update type * lint * pubmaticBidAdapter: use getAdUnitElement * placement position: use getAdUnitElement --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com> * Prebid 11: native event trackers handling (#14524) * Prebid 11: native event trackers handling * field name fix * Prebid 11: gpt slots matching to ad units logic unification (#14480) * Promoting customSlotMatching to config * Update gptPreAuction.ts * Update gptPreAuction.ts * renaming --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com> * Module: Remove dmd userid module (#14545) * Remove dmd userid module * Remove dmd userId module test coverage --------- Co-authored-by: mfitzgerald_dmd <mfitzgerald@dmdconnects.com> * lint fix * Prebid 11: document encouraging TypeScript for new source files (#14488) * Docs: require TypeScript for new src/modules/libraries files * Encourage TypeScript for new files in specific directories Rephrase recommendation for TypeScript usage in new files. * Update PR_REVIEW.md * CI: comment on newly added JS files in TS paths (#14526) * Reword to focus on public interface * Update linter.yml Linter check comment --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * Prebid 11: Bid viewability event trackers (#14505) * Prebid 11: Bid viewability event trackers * naming conflict fix * sspBCBidAdapter vurls fallback * removing firePixels config, fixing event listener, removing gdpr, adding lib spec file * native & js handling * lint * revert adapter changes * revert * remove gpt impression listener first * sspBCBidAdapter refactor * sspBCBidAdapter tests fix * missing import * Update bidViewability.js --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com> * Prebid 11: remove intersectionRtdProvider, use IntersectionObserver in percentInView (#14525) * Core: add elementSelector property of ad units * core: use getAdUnitElement * various adapters: use getAdUnitElement * various modules: use getAdUnitElement * various adapters: use getAdUnitElement * use .element, not .elementSelector * lint * fix secureCreatives tests * Update ixBidAdapter.js * Remove TODO note; update type * lint * pubmaticBidAdapter: use getAdUnitElement * placement position: use getAdUnitElement * percentInView: use IntersectionObserver * adlooxRtdProvider: do not depend on intersectionObserver * remove intersectionrtdprovider * check the right element has intersected * keep size override * handle missing intersection observer * Fix tests * DOMRect weirdness * remove unnecessary sort * More aggressive static fallback * Update percentInView.js * Update percentInView.js * whitespace --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com> * Prebid 11: toss mediatype mismatch bids; avoid mediaType mismatch rejects when adapter omits mediaType (#14496) * Core: preserve omitted mediaType behavior in bid validation * Update bidderFactory to retain mediaType Retain mediaType information from adapter response. * tests fixing * lint * Core: split unknown vs invalid mediaType rejection flags (#14569) --------- Co-authored-by: mkomorski <marcin.komorski@pollub.edu.pl> * adloox analytics: do not disable if not enabled * connatixBidAdapter: fix tests * connatixBidAdapter: fix the fix to the test * percentInView: add timeout, adjust intersection thresholds (#14579) * remove debugger statement * mediaFuse: fix test failing on safari (regex lookbehind not supported) * Revert "mediaFuse: fix test failing on safari (regex lookbehind not supported)" This reverts commit 85860a8. * mediafuse: reapply adpod changes * mediafuse: fix lint * mediafuse: use getAdUnitElement * magnite utils: use getAdUnitElement * Prebid 11: normalize onBidViewable behavior (#14586) * Prebid 11: normalize onBidViewable behavior * lint * Delete scope3_segtax_pr.md * taboola: fix missing import --------- Co-authored-by: dpapworth-qc <50959025+dpapworth-qc@users.noreply.github.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: mkomorski <marcin.komorski@pollub.edu.pl> Co-authored-by: Matt Fitzgerald <matthewfitz@gmail.com> Co-authored-by: mfitzgerald_dmd <mfitzgerald@dmdconnects.com>
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
* StroeerCore Bid Adapter: add support for TIDs and GPID * Fix lint
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
* Various modules: revert GPT targeting changes * keep intentiq changes
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.1 to 3.4.1. - [Commits](WebReflection/flatted@v3.3.1...v3.4.1) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [undici](https://github.com/nodejs/undici) from 6.23.0 to 6.24.1. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.23.0...v6.24.1) --- updated-dependencies: - dependency-name: undici dependency-version: 6.24.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
1 similar comment
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
…ustness (#14530) * Holid: respect auction timeout, safer ortb merges, improve usersync * Holid Bid Adapter: add unit tests * chore: re-run CI
|
Tread carefully! This PR adds 23 linter errors (possibly disabled through directives):
|
20 participants
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )