Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
gosec found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
===========================================
- Coverage 68.50% 47.39% -21.12%
===========================================
Files 9 13 +4
Lines 978 1842 +864
===========================================
+ Hits 670 873 +203
- Misses 286 944 +658
- Partials 22 25 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| clusterJoinCmd.Flags().StringVarP(&leaderAddr, "leader", "l", "", "Leader address (required)") | ||
| clusterJoinCmd.Flags().StringVarP(&joinNodeID, "node-id", "n", "", "Node ID to join (required)") | ||
| clusterJoinCmd.Flags().StringVarP(&joinNodeAddr, "node-addr", "a", "", "Node address (required)") | ||
| clusterJoinCmd.MarkFlagRequired("leader") |
Check warning
Code scanning / gosec
Errors unhandled Warning
| clusterJoinCmd.Flags().StringVarP(&joinNodeID, "node-id", "n", "", "Node ID to join (required)") | ||
| clusterJoinCmd.Flags().StringVarP(&joinNodeAddr, "node-addr", "a", "", "Node address (required)") | ||
| clusterJoinCmd.MarkFlagRequired("leader") | ||
| clusterJoinCmd.MarkFlagRequired("node-id") |
Check warning
Code scanning / gosec
Errors unhandled Warning
| clusterJoinCmd.Flags().StringVarP(&joinNodeAddr, "node-addr", "a", "", "Node address (required)") | ||
| clusterJoinCmd.MarkFlagRequired("leader") | ||
| clusterJoinCmd.MarkFlagRequired("node-id") | ||
| clusterJoinCmd.MarkFlagRequired("node-addr") |
Check warning
Code scanning / gosec
Errors unhandled Warning
| nodeStartCmd.Flags().IntVar(&dashboardPort, "dashboard-port", 9003, "Dashboard port") | ||
| nodeStartCmd.Flags().StringVarP(&joinAddr, "join", "j", "", "Address of node to join") | ||
| nodeStartCmd.Flags().BoolVarP(&bootstrapCluster, "bootstrap", "b", false, "Bootstrap new cluster") | ||
| nodeStartCmd.MarkFlagRequired("node-id") |
Check warning
Code scanning / gosec
Errors unhandled Warning
| nodeMultiCmd.Flags().StringVarP(&liveNodeID, "node-id", "n", "", "Node ID (required)") | ||
| nodeMultiCmd.Flags().IntVarP(&livePort, "port", "p", 8001, "Port") | ||
| nodeMultiCmd.Flags().StringVarP(&liveJoin, "join", "j", "", "Address of node to join") | ||
| nodeMultiCmd.MarkFlagRequired("node-id") |
Check warning
Code scanning / gosec
Errors unhandled Warning
|
|
||
| // Stop Raft | ||
| if app.raftManager != nil { | ||
| app.raftManager.Shutdown() |
Check warning
Code scanning / gosec
Errors unhandled Warning
| go func() { | ||
| <-c | ||
| app.logger.Info("🛑 Received shutdown signal...") | ||
| app.Stop() |
Check warning
Code scanning / gosec
Errors unhandled Warning
| fmt.Println("🚀 Starting 3-node cluster demo...") | ||
|
|
||
| // Get data directory from global flags | ||
| dataDir, _ := cmd.Flags().GetString("data-dir") |
Check warning
Code scanning / gosec
Errors unhandled Warning
|
|
||
| func runCleanup(cmd *cobra.Command, args []string) error { | ||
| // Get data directory from global flags | ||
| dataDir, _ := cmd.Flags().GetString("data-dir") |
Check warning
Code scanning / gosec
Errors unhandled Warning
1 participant
Add pickbox cli