Skip to content

DS-change-default-crop-image #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maximeallanic merged 2 commits into from
Jun 24, 2025
Merged

DS-change-default-crop-image #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc44486
fix: update default selected aspect ratio to 4:5 in ACropPrompt compo…
PierreGAMEN Jun 13, 2025
dbb0df0
fix: improve aspect ratio selection and labels in ACropPrompt component
PierreGAMEN Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 54 additions & 30 deletions components/Prompt/ACropPrompt.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import AButton from "../AButton.vue";
import ACrop from "../ACrop.vue";
import { toValue } from "@vueuse/core";
import AInputRadio from "../AInputRadio.vue";
import { useTranslate } from "@addeus/vue3-stores/stores/translate";
import { ref } from "vue";

export interface ACropPromptEmits {
Expand All @@ -26,63 +27,86 @@ export interface ACropPromptProps {
quality?: number;
}

const selectedOption = ref<string | undefined>("1:1");
const selectedOption = ref<string>("4:5");
const props = defineProps<ACropPromptProps>();
const portraitLabel = useTranslate("crop.portrait");
const squareLabel = useTranslate("crop.square");
const landscapeLabel = useTranslate("crop.landscape");
const model = defineModel();
</script>

<template>
<AModal :open="true" @close="$emit('cancel')" :title="toValue(title)">
<AModal :open="true" @close="$emit('cancel')" :title="toValue(props.title)">
<template #content>
<div class="container-ratio">
<label>Ratio:</label>
<label>Ratio :</label>

<AInputRadio
v-model="selectedOption"
name="aspectRatio"
value="4:5">4:5</AInputRadio>
value="4:5"
>
{{ portraitLabel || '4:5' }}
</AInputRadio>

<AInputRadio
v-model="selectedOption"
name="aspectRatio"
value="1:1"
label="1:1"
>1:1</AInputRadio>
>
{{ squareLabel || '1:1' }}
</AInputRadio>

<AInputRadio
v-model="selectedOption"
name="aspectRatio"
value="5:4"
>
{{ landscapeLabel || '5:4' }}
</AInputRadio>
</div>
<ACrop v-model="model"
:aspectRatio="selectedOption === '4:5' ? 4/5 : 1"
:maxHeight="maxHeight"
:maxWidth="maxWidth"
:mimeType="mimeType"
:minHeight="minHeight"
:minWidth="minWidth"
:quality="quality"
></ACrop>

<ACrop
v-model="model"
:aspectRatio="selectedOption === '4:5' ? 4 / 5 : selectedOption === '5:4' ? 5 / 4 : 1"
:maxHeight="props.maxHeight"
:maxWidth="props.maxWidth"
:mimeType="props.mimeType"
:minHeight="props.minHeight"
:minWidth="props.minWidth"
:quality="props.quality"
/>
</template>
<template #action>

<AButton @click="$emit('cancel')">{{
toValue(cancel)
}}</AButton>
<AButton @click="$emit('confirm')" color="primary">{{
toValue(confirm)
}}</AButton>

<template #action>
<AButton @click="$emit('cancel')">{{ toValue(props.cancel) }}</AButton>
<AButton @click="$emit('confirm')" color="primary">{{ toValue(props.confirm) }}</AButton>
</template>
</AModal>
</template>

<style lang="scss" scoped>
.container-ratio {
margin-bottom: 1rem;
display: flex;
gap: 10px;
align-items: center;
gap: 1rem;

label {
white-space: nowrap;
}

.a-input-radio{
width: 50px;
min-width: inherit;
.a-input-radio {
display: flex;
align-items: center;
min-width: 80px;
flex-shrink: 0;
}

:deep(.label-text) {
padding: 0;
width: 20px !important;
}
margin-left: 0.5rem;
white-space: nowrap;
}
}

</style>