Add parameterized display_js and video_vast formats #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two new template formats that accept parameters, enabling the sales agent's template picker to validate user-configured templates: - display_js: JavaScript-based display ads accepting dimensions parameter - video_vast: VAST video ads accepting duration parameter (parameterized version of the existing fixed video_vast_30s format) Fixes #40 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use the dedicated `vast` asset type instead of `text` for VAST tag assets. Also fixes the existing video_vast_30s format which had the same issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove duplicative description and max_file_size_mb fields from asset requirements - they don't add value beyond the format-level description. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The accepts_parameters field on the format already indicates which parameters are accepted from FormatId. Having parameters_from_format_id on each asset was redundant and not actually used by any code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new parameterized template formats for the sales agent's template picker:
dimensionsparameterdurationparameter (parameterized version of existingvideo_vast_30s)This brings the total template formats from 5 to 7, enabling the sales agent UI to validate user-configured templates combining format IDs with dimensions or duration values.
Fixes #40
Test plan
🤖 Generated with Claude Code