Skip to content

fix: prevent injecting push notification config for unsupported tools#170

Closed
youbek wants to merge 1 commit intoadcontextprotocol:mainfrom
youbek:fix/prevent-injecting-push-notification-config-for-unsupported-tools
Closed

fix: prevent injecting push notification config for unsupported tools#170
youbek wants to merge 1 commit intoadcontextprotocol:mainfrom
youbek:fix/prevent-injecting-push-notification-config-for-unsupported-tools

Conversation

@youbek
Copy link
Copy Markdown
Collaborator

@youbek youbek commented Dec 14, 2025

  • Some tools do not support push_notification_config. But we were injecting them always as long as the client has webhookTemplate configured.
  • This resulted in errors such as: Fix get_media_buy_delivery failing with "Unexpected keyword argument: push_notification_config"

This PR adds tool name check before auto injecting push_notification_config.

@bokelley
Copy link
Copy Markdown
Contributor

@youbek close?

@bokelley bokelley closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants