This repository was archived by the owner on Feb 2, 2026. It is now read-only.
Upgrade libraries and some bug fixes#29
Open
dgchurchill wants to merge 44 commits intomasterfrom
unknown repository
Open
Upgrade libraries and some bug fixes#29dgchurchill wants to merge 44 commits intomasterfrom unknown repository
dgchurchill wants to merge 44 commits intomasterfrom
unknown repository
Conversation
Also typed the parameter as TimeSpan instead of int.
Conflicts: src/Eventful.CsTests/packages.config src/Eventful.EventStore/packages.config
Conflicts: src/Eventful.CsTests/packages.config src/Eventful.EventStore/packages.config src/Eventful.Neo4j/packages.config src/Eventful.RavenDb/packages.config src/Eventful/packages.config
Previously, subqueries would be executed once for each row in result from the parent query. This mean that when, e.g., replacing all relationships on a permission where we'd delete all the relationships first, the newly added relationships would be added once per relationship that was deleted. Using an aggregate fuction (here, `count(*)`), we ensure we only get one result row from the parent query and thus run the subquery only once.
Reintegrate with master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit ugly and not sure if you want it all, but it gets everything up-to-date with where we currently are. It's mostly package version updates but also has a couple of bug fixes which could be worth cherry-picking if you don't take the whole thing:
There are also a couple of commits that add some extra logging