Extract TelemetryHelper for shared telemetry logic\n\nTask ID: task-2.1-extract-telemetry-helper

[jadewang-db]

🥞 Stacked PR

Use this link to review incremental changes.

• stack/fix-telemetry-gaps-design [Files changed]
  • stack/pr-phase1-thrift-telemetry-gaps [Files changed]
    • stack/pr-phase2-sea-telemetry [Files changed]

---

What's Changed

Please fill in a description of the changes here.

This contains breaking changes.

Closes #NNN.

[jadewang-db]

Range-diff: stack/pr-phase1-thrift-telemetry-gaps (adca408 -> 5b65a42)

csharp/src/DatabricksConnection.cs

@@ -127,6 +127,7 @@
 -        private Telemetry.Proto.DriverSystemConfiguration BuildSystemConfiguration()
 -        {
 -            var osVersion = System.Environment.OSVersion;
+-            var processName = System.Diagnostics.Process.GetCurrentProcess().ProcessName;
 -            return new Telemetry.Proto.DriverSystemConfiguration
 -            {
 -                DriverVersion = s_assemblyVersion,
@@ -139,16 +140,16 @@
 -                RuntimeVendor = "Microsoft",
 -                LocaleName = System.Globalization.CultureInfo.CurrentCulture.Name,
 -                CharSetEncoding = System.Text.Encoding.Default.WebName,
--                ProcessName = System.Diagnostics.Process.GetCurrentProcess().ProcessName,
--                ClientAppName = GetClientAppName()
+-                ProcessName = processName,
+-                ClientAppName = GetClientAppName(processName)
 -            };
 -        }
 -
--        private string GetClientAppName()
+-        private string GetClientAppName(string processName)
 -        {
 -            // Check connection property first, fall back to process name
 -            Properties.TryGetValue("adbc.databricks.client_app_name", out string? appName);
--            return appName ?? Process.GetCurrentProcess().ProcessName;
+-            return appName ?? processName;
 -        }
 -
 -        private Telemetry.Proto.DriverConnectionParameters BuildDriverConnectionParams(bool isAuthenticated)

csharp/src/StatementExecution/StatementExecutionConnection.cs

@@ -183,5 +183,5 @@
 +        }
 +
          // TracingConnection provides IActivityTracer implementation
-         public override string AssemblyVersion => GetType().Assembly.GetName().Version?.ToString() ?? "1.0.0";
-         public override string AssemblyName => "AdbcDrivers.Databricks";
\ No newline at end of file
+         internal bool EnableComplexDatatypeSupport => _enableComplexDatatypeSupport;
+ 
\ No newline at end of file

csharp/src/StatementExecution/StatementExecutionStatement.cs

@@ -169,12 +169,18 @@
 +                            { "total_byte_count", response.Manifest.TotalByteCount }
 +                        }));
 +                }
-+
+ 
+-            // Create appropriate reader based on result disposition
+-            IArrowArrayStream reader = CreateReader(response, cancellationToken);
 +                // Create appropriate reader based on result disposition
 +                IArrowArrayStream reader = CreateReader(response, cancellationToken);
  
--            // Create appropriate reader based on result disposition
--            IArrowArrayStream reader = CreateReader(response, cancellationToken);
+-            // When EnableComplexDatatypeSupport=false (default), serialize complex Arrow types to JSON strings
+-            // so that SEA behavior matches Thrift (which sets ComplexTypesAsArrow=false).
+-            if (!_enableComplexDatatypeSupport)
+-            {
+-                reader = new ComplexTypeSerializingStream(reader);
+-            }
 +                // Get schema from reader
 +                var schema = reader.Schema;
  
@@ -184,8 +190,8 @@
 +                long rowCount = response.Manifest?.TotalRowCount ?? -1;
 +                QueryResult result = new QueryResult(rowCount, reader);
  
--            // Return query result - use -1 if row count is not available
--            long rowCount = response.Manifest?.TotalRowCount ?? -1;
+-            // Return query result - use 0 if row count is not available
+-            long rowCount = response.Manifest?.TotalRowCount ?? 0;
 -            return new QueryResult(rowCount, reader);
 +                // Record success and determine result format from disposition
 +                if (ctx != null)
@@ -342,7 +348,7 @@
 +                throw;
              }
 -
--            // For updates, we don't need to read the results - just return the row count
+-            // For updates, we don't need to read the results - just return the row count.
 -            long rowCount = response.Manifest?.TotalRowCount ?? 0;
 -            return new UpdateResult(rowCount);
          }

_{Reproduce locally: git range-diff 065621b..adca408 d504b0a..5b65a42 | Disable: git config gitstack.push-range-diff false}