fix(csharp): throw ArgumentException for GetPrimaryKeys with null table name (PECO-2956)#342
Open
msrathore-db wants to merge 1 commit intomainfrom
Open
Conversation
…le name (PECO-2956) GetPrimaryKeys in SEA mode silently returned an empty result when table name was null, while Thrift mode threw via the server. Add client-side validation in both protocols so they consistently throw ArgumentException. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
msrathore-db
requested a deployment
to
azure-prod
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArgumentExceptionvalidation for null/empty table name in both SEA (StatementExecutionStatement.cs) and Thrift (DatabricksStatement.cs) pathsArgumentException("Table name is required for GetPrimaryKeys")before any server callTest plan
GetPrimaryKeyswith null table name throwsArgumentExceptionin SEA modeGetPrimaryKeyswith null table name throwsArgumentExceptionin Thrift modeGetPrimaryKeyswith valid table name still works in both modesGetColumnsExtended(which callsGetPrimaryKeysinternally) still works with valid paramsCloses PECO-2956
🤖 Generated with Claude Code