Skip to content

Fix: Check _canShowCorrectness value before applying item-level classes (#240)#241

Merged
oliverfoster merged 2 commits intomasterfrom
isse/240
Jan 7, 2026
Merged

Fix: Check _canShowCorrectness value before applying item-level classes (#240)#241
oliverfoster merged 2 commits intomasterfrom
isse/240

Conversation

@cahirodoherty-learningpool
Copy link
Copy Markdown
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool commented Dec 22, 2025

Fixes #240

Fix

  • Check _canShowCorrectness value before applying item-level classes

@cahirodoherty-learningpool cahirodoherty-learningpool moved this from New to Needs Reviewing in adapt_framework: The TODO Board Dec 22, 2025
Copilot AI reviewed Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #240 by ensuring that item-level correctness classes (is-correct and is-incorrect) are only applied when the _canShowCorrectness configuration is enabled. Additionally, it corrects a typo in the pull request template.

  • Added _canShowCorrectness check to item-level class conditions for consistent behavior with component-level correctness display
  • Fixed typo in pull request template ("udpate" → "update")

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
templates/mcq.jsx Added _canShowCorrectness check before applying is-correct and is-incorrect classes to individual MCQ items, ensuring consistency with the component-level correctness display configuration
.github/pull_request_template.md Fixed spelling error in the "Update" section header

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

oliverfoster
oliverfoster reviewed Jan 7, 2026
View reviewed changes
Comment thread templates/mcq.jsx
@oliverfoster oliverfoster merged commit 376a19f into master Jan 7, 2026
6 checks passed
@oliverfoster oliverfoster deleted the isse/240 branch January 7, 2026 16:23
@github-project-automation github-project-automation Bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jan 7, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 7, 2026
@semantic-release-bot
Chore(release): 7.6.1 [skip ci]
e89a572 
## [7.6.1](v7.6.0...v7.6.1) (2026-01-07)

### Fix

* Check _canShowCorrectness value before applying item-level classes (#240) (#241) ([376a19f](376a19f)), closes [#240](#240) [#241](#241)
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 7, 2026

🎉 This PR is included in version 7.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster
Copy link
Copy Markdown
Member

oliverfoster commented Jan 9, 2026 •
edited
Loading

I'm still conflicted on this.

_canShowCorrectness is an alternative to _canShowModelAnswer as a way of displaying answer correctness. _canShowCorrectness is not for turning on and off question correctness, which is what _canShowMarking is for.

Original prs

@oliverfoster oliverfoster mentioned this pull request Mar 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverfoster oliverfoster oliverfoster left review comments

Copilot code review Copilot Copilot left review comments

@joe-replin joe-replin joe-replin approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@lemmyadams lemmyadams lemmyadams approved these changes

@swashbuck swashbuck Awaiting requested review from swashbuck

Assignees

@cahirodoherty-learningpool cahirodoherty-learningpool

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correctness is displaying on items even when _canShowCorrectness is false

6 participants

@cahirodoherty-learningpool @oliverfoster @joe-replin @ethan-lp @lemmyadams