Update: Matching dropdown uses trickle helper for layout (fixes #207)#208
Closed
joe-replin wants to merge 3 commits intomasterfrom
Closed
Update: Matching dropdown uses trickle helper for layout (fixes #207)#208joe-replin wants to merge 3 commits intomasterfrom
joe-replin wants to merge 3 commits intomasterfrom
Conversation
Removed unused state variables for list height, button width, and button offset. Simplified calculations for dropdown positioning.
joe-replin
changed the title
ethan-lp
approved these changes
Jan 8, 2026
Member
|
Cannot reproduce in vanilla adapt. Suggest to be an issue with the course rather than Adapt? |
github-project-automation
Bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Testing
Dependencies
Dependent on this trickle PR: adaptlearning/adapt-contrib-trickle#248