refactor(framework): Remove GetRunStatus endpoint #6507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated GetRunStatus endpoint from both the SimulationIo and ServerAppIo services, streamlining the API surface by eliminating redundant functionality.
Changes:
- Removed
GetRunStatusRPC method from protobuf service definitions - Removed
GetRunStatusmethod implementations from servicers - Removed unused import
run_status_to_protofrom both servicers - Removed protobuf message definitions
GetRunStatusRequestandGetRunStatusResponse
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| framework/py/flwr/server/superlink/simulation/simulationio_servicer.py | Removed GetRunStatus method implementation and unused imports |
| framework/py/flwr/server/superlink/serverappio/serverappio_servicer.py | Removed GetRunStatus method implementation and unused imports |
| framework/proto/flwr/proto/simulationio.proto | Removed GetRunStatus RPC definition from service |
| framework/proto/flwr/proto/serverappio.proto | Removed GetRunStatus RPC definition from service |
| framework/proto/flwr/proto/run.proto | Removed GetRunStatusRequest and GetRunStatusResponse message definitions |
| framework/py/flwr/proto/simulationio_pb2_grpc.pyi | Regenerated gRPC stubs without GetRunStatus |
| framework/py/flwr/proto/simulationio_pb2_grpc.py | Regenerated gRPC implementation without GetRunStatus |
| framework/py/flwr/proto/simulationio_pb2.py | Updated protobuf binary descriptor |
| framework/py/flwr/proto/serverappio_pb2_grpc.pyi | Regenerated gRPC stubs without GetRunStatus |
| framework/py/flwr/proto/serverappio_pb2_grpc.py | Regenerated gRPC implementation without GetRunStatus |
| framework/py/flwr/proto/serverappio_pb2.py | Updated protobuf binary descriptor |
| framework/py/flwr/proto/run_pb2.pyi | Removed type stubs for GetRunStatus messages |
| framework/py/flwr/proto/run_pb2.py | Updated protobuf binary descriptor |
Comments suppressed due to low confidence (1)
framework/py/flwr/server/superlink/simulation/simulationio_servicer.py:1
- Corrected spelling of 'SimultionIoServicer' to 'SimulationIoServicer'.
# Copyright 2025 Flower Labs GmbH. All Rights Reserved.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
Maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.