refactor(framework): Let typer.Exit pass through
#6505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panh99
requested review from
danieljanes,
jafermarq and
tanertopal
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the cli_output_handler context manager in the Flwr CLI framework to allow typer.Exit exceptions to propagate through without being caught by the general exception handler.
Changes:
- Added explicit handling for
typer.Exitexceptions to re-raise them immediately
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+98
to
+99
| except typer.Exit: # Allow typer.Exit to pass through | ||
| raise |
There was a problem hiding this comment.
The new typer.Exit exception handling path lacks test coverage. Consider adding a test case that verifies typer.Exit exceptions are properly re-raised and not caught by the general exception handler.
github-actions
bot
added
the
Maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.