Skip to content

feat: add semantic embedding support to MemoryRecallPipeline#8

Open
BiswasNehaa wants to merge 1 commit into
adam2go:mainfrom
BiswasNehaa:feat/semantic-memory-recall
Open

feat: add semantic embedding support to MemoryRecallPipeline#8
BiswasNehaa wants to merge 1 commit into
adam2go:mainfrom
BiswasNehaa:feat/semantic-memory-recall

Conversation

@BiswasNehaa

Copy link
Copy Markdown

Closes #7

What

  • Implements _semantic_score() using sentence-transformers (optional dependency)
  • Stores embeddings in Memory.embedding on creation via MemoryWriter.create_candidate
  • Falls back gracefully to None when sentence-transformers isn't installed or no embedding exists
  • Adds sentence-transformers as an optional embeddings extra in pyproject.toml
  • Adds a regression test verifying graceful fallback behavior

Testing

Ran python -m pytest tests/test_memory_lifecycle.py -v — both tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add semantic embedding support to MemoryRecallPipeline

1 participant