feat: Inclination dependent SurfaceArray lookup#5186
Merged
asalzburger merged 29 commits intoacts-project:mainfrom Apr 1, 2026
Merged
feat: Inclination dependent SurfaceArray lookup#5186asalzburger merged 29 commits intoacts-project:mainfrom
SurfaceArray lookup#5186asalzburger merged 29 commits intoacts-project:mainfrom
Conversation
Contributor
…ination-dependent-surface-array-lookup
Contributor
Author
|
I saw some performance degradation with this + main vs v45.5.1 which may come from main itself or from this change. I will try to narrow this down and reduce the indirection from the |
…dependent-surface-array-lookup
…dependent-surface-array-lookup
…dependent-surface-array-lookup
…dependent-surface-array-lookup
…om:andiwand/acts into inclination-dependent-surface-array-lookup
|
Collaborator
acts-project-service
added
the
Fails Athena tests
andiwand
removed
the
Fails Athena tests
andiwand
added a commit
to andiwand/acts
that referenced
this pull request
Apr 1, 2026
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
- more deprecations - remove `const_cast` - deduplicate the surface array checking code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scales the neighborhood lookup depending on the inclination between propagation direction and surface normal.
This is a naive "first order" approximation where we assume the "uncertainty" is distance 1 in local grid units given perpendicular approach. This "uncertainty" is then scaled with$\frac{1}{\cos(\theta)}$ where $\theta$ is the enclosed angle between the grid surface and the track direction. An upper limit is deployed which also cuts off the generation of the next neighbor lookup table.
--- END COMMIT MESSAGE ---
An alternative formulation would be to assume a layer thickness and project it on the layer surface depending on the inclination.
One could go even further and make the lookup path dependent. But that clashes with our current assumption that the neighborhood is resolved once during initialization.