Refactor speech processing to use extension points#11
Closed
Conversation
Replace direct function overrides with a clean extension point architecture: - Add extensionPoints.py: Filter/Action classes for registering handlers - Add textProcessors.py: TextProcessor base class and EnglishToKanaProcessor - Add speechHook.py: SpeechHookManager for clean hook lifecycle management This allows text processors to be registered/unregistered without monkey-patching, making the code more maintainable and extensible.
Contributor
Author
|
実装見ていると複雑性がやたら増しているので、今のところ解くに要望もないし閉じようと思います。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct function overrides with a clean extension point architecture:
This allows text processors to be registered/unregistered without
monkey-patching, making the code more maintainable and extensible.