Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ updates:
github_actions:
patterns:
- "*"
cooldown:
default-days: 5
- package-ecosystem: bundler
directory: /
schedule:
Expand All @@ -17,6 +19,8 @@ updates:
bundler:
patterns:
- "*"
cooldown:
default-days: 5
- package-ecosystem: npm
directory: /
schedule:
Expand All @@ -26,6 +30,5 @@ updates:
npm:
patterns:
- "*"
ignore:
- dependency-name: "tailwindcss"
versions: ">= 4.0"
cooldown:
default-days: 5
4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ jobs:
with:
ruby-version: .ruby-version
bundler-cache: true
- uses: actions/setup-node@v6
with:
node-version-file: .node-version
cache: npm
- name: Run tests
env:
COVERAGE: true
Expand Down
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lts/krypton
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer we are explicit with the version number so we should use 24.14.1. Follows the same approach as Ruby with an explicit version.

Suggested change
lts/krypton
24.14.1

1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ignore-scripts=true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to include this? I don't want to break to watch commands for local development for this app. I understand the concern with security but I don't think it's worth it for a demo app. Is there an alternative without breaking the watch commands?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution would be pnpm with explicit post-install allowance, but then I guess that the supply chain attacks will be directed to such packages

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I test that watch does not work without post-install?

2 changes: 1 addition & 1 deletion Procfile.dev
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
web: env RUBY_DEBUG_OPEN=true bin/rails server
css: yarn build:css --watch
css: npm run build:css -- --watch
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,10 @@ https://activeadmin-demo.onrender.com
## Development Setup

- Clone this repository
- Install Ruby 4.0 with [rbenv](https://github.com/rbenv/rbenv)
- Install Node 24 with [nodenv](https://github.com/nodenv/nodenv)
- `corepack enable`
- Install Ruby with [rbenv](https://github.com/rbenv/rbenv) or [mise](https://mise.jdx.dev/) (see `.ruby-version` for the required version)
- Install Node with [nodenv](https://github.com/nodenv/nodenv) or [mise](https://mise.jdx.dev/) (see `.node-version` for the required version)
- `bundle install`
- `yarn install`
- `npm install`
- `bin/rails db:seed`
- `bin/dev`

Expand Down
Loading