-
Notifications
You must be signed in to change notification settings - Fork 625
[v5] Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: releases/v5
Are you sure you want to change the base?
[v5] Fall back to downloading from go.dev/dl instead of storage.googleapis.com/golang #666
Conversation
|
Hello @nicholasngai, Thanks for this pull request. Could you also include the audit-related fixes as part of this change, just for the releases/v5 branch to move forward. |
|
Hi @aparnajyothi-y! What audit-related fixes are you referring to? |
|
@aparnajyothi-y Hey, just bumping this question. :) |
|
@nicholasngai I believe @aparnajyothi-y is referring to https://github.com/actions/setup-go/actions/runs/18602396198/job/53580106842?pr=666, some npm packages need to be updated to resolve security issues. |
|
Hi @nicholasngai, apologies for the delay and thank you for following up. Yes, as @rolandshoemaker pointed out, I was referring to the security audit fixes needed for the releases/v5 branch by running npm audit fix command. specifically updating the npm packages flagged in the audit report to ensure we resolve the security warnings. It would be great if we could include those updates along with this change so the v5 branch stays compliant. |
|
@aparnajyothi-y Sorry for the delay here! I ran |
|
Hi @nicholasngai , the checks are still failing, but given the community interest and the broader value of this update, we’re moving forward with incorporating these changes so that the v5 branch remains fully compliant for release. Please let me know if you need any additional details. Thanks again for your contribution and really appreciate the effort! |
Description:
Cherry-picking #665 onto v5.
Related issue:
Closes #664.
Check list: