Skip to content

Conversation

@daniel-montalvo
Copy link
Collaborator

@daniel-montalvo daniel-montalvo commented Jan 20, 2026

Update the gh actions versions as well as node versions to run these scripts.

Need for Call for Review:
This can be merged with 1 approval << choose reason: editorial changes to website/test code.


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@netlify
Copy link

netlify bot commented Jan 20, 2026

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit c7f13c4
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/696fce2eaeae0c0008f09471
😎 Deploy Preview https://deploy-preview-2379--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daniel-montalvo daniel-montalvo self-assigned this Jan 20, 2026
@daniel-montalvo daniel-montalvo added the javascript Pull requests that update javascript code label Jan 20, 2026
@daniel-montalvo
Copy link
Collaborator Author

@WilcoFiers @Jym77 I'm not familiar enough with the ACT-tools codebase to garantee that this would work, but I also couldn't find obvious reasons for it not to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants