update envo #2343
Closed
update envo #2343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c's disallowed autocomplete values for specific form controls (#2161) * solving discussion in 1967 Added accessibility support note and removed "ambiguous example" * Update autocomplete-valid-value-73f2c2.md Replaced "Certain `autocomplete` attribute values are appropriate only for specific form controls. However, despite some combinations of `autocomplete` attribute values and form controls not being allowed by HTML specifications, the input purpose is programmatically available, and autocomplete functions correctly. Thus, if the input possesses the suitable autocomplete value, it fulfills the [Success Criterion 1.3.5 Identify Input Purpose](https://www.w3.org/TR/WCAG22/#identify-input-purpose), regardless of the input type." with "Authors may assign inappropriate `autocomplete` attribute values. Moreover, HTML specifications restrict certain `autocomplete` attribute values to specific form controls. Mismatches between `autocomplete` attribute values and form control types may or may not lead to a failure of [Success Criterion 1.3.5 Identify Input Purpose](https://www.w3.org/TR/WCAG22/#identify-input-purpose). However, this rule focuses exclusively on validating valid `autocomplete` attribute values, disregarding their contextual appropriateness." --------- Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.9...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dary requirements for 1.3.1 and 2.5.3 (#2188) * Added secondary requirements * Update _rules/form-field-non-empty-accessible-name-e086e5.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/form-field-non-empty-accessible-name-e086e5.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/form-field-non-empty-accessible-name-e086e5.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com> --------- Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
…nt purpose" [fd3a94]: Reduced images size for failed examples [4,8] (#2178) * Update links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md * Update links-with-identical-names-and-context-serve-equivalent-purpose-fd3a94.md --------- Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
* New rule: Summary element has non-empty accessible name * Fix tests * Apply suggestions from code review Co-authored-by: Tom Brunet <thbrunet@us.ibm.com> * Update summary-non-empty-accessible-name-2t702h.md * Update _rules/summary-non-empty-accessible-name-2t702h.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/summary-non-empty-accessible-name-2t702h.md * Update _rules/summary-non-empty-accessible-name-2t702h.md * Update _rules/summary-non-empty-accessible-name-2t702h.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Giacomo Petri <giacomo.petri@usablenet.com> * Update _rules/summary-non-empty-accessible-name-2t702h.md Co-authored-by: Giacomo Petri <giacomo.petri@usablenet.com> * Update _rules/summary-non-empty-accessible-name-2t702h.md * Update _rules/summary-non-empty-accessible-name-2t702h.md * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/summary-non-empty-accessible-name-2t702h.md --------- Co-authored-by: Tom Brunet <thbrunet@us.ibm.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Giacomo Petri <giacomo.petri@usablenet.com>
* Added text-shadow failed example * Update _rules/text-contrast-afw4f7.md Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update text-contrast-afw4f7.md * Update text-contrast-afw4f7.md * Update spelling-ignore.yml --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
…title" (#2181) Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* fix-broken-summary-link * Add link destination to ensure it works properly * Update summary-non-empty-accessible-name-2t702h.md --------- Co-authored-by: Daniel <dmontalvo@w3.org>
…d as failed example 6 (#2180) * Shadow root example included as failed example 6 * Update _rules/html-page-non-empty-title-2779a5.md Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
…gation" [0ssw9k]: scrollable regions pass when there is an open modal (#2219) * scrollable regions should pass when there is an open modal - updated expectation to exclude inert elements from sequential focus - added passing example * Update _rules/scrollable-element-keyboard-accessible-0ssw9k.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update scrollable-element-keyboard-accessible-0ssw9k.md --------- Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* Bump braces and jest-extended Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependency [jest-extended](https://github.com/jest-community/jest-extended). These dependencies need to be updated together. Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) Updates `jest-extended` from 0.11.5 to 4.0.2 - [Release notes](https://github.com/jest-community/jest-extended/releases) - [Changelog](https://github.com/jest-community/jest-extended/blob/main/CHANGELOG.md) - [Commits](jest-community/jest-extended@v0.11.5...v4.0.2) --- updated-dependencies: - dependency-name: braces dependency-type: indirect - dependency-name: jest-extended dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * correct how jest-extended is included --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wilco Fiers <wilco.fiers@deque.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
* Update to rules format 1.1 * Update mention to rules format from 1.0 to 1.1 in rule design * Update pages/design/rule-design.md --------- Co-authored-by: Carlos Duarte <caduarte@edu.ulisboa.pt>
* Tweak image-description rule * Update _rules/image-button-non-empty-accessible-name-59796f.md Co-authored-by: sage-putnam <163018910+sage-putnam@users.noreply.github.com> --------- Co-authored-by: sage-putnam <163018910+sage-putnam@users.noreply.github.com>
* Update a1b64e Pass 2 to add role * Add a support note for issue 1909 regarding cycle to browser * Add a passing modal example * Fix spacing * Fix spacing --------- Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
…2194) * Correct descriptions of failed examples * Update _rules/html-page-lang-valid-bf051a.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/html-page-lang-valid-bf051a.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> --------- Co-authored-by: Carlos Duarte <caduarte@edu.ulisboa.pt> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
* Editorial tweaks to object name rule * Update _rules/object-has-accessible-name-8fc3b6.md Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com> --------- Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
* Add 1.1.1 secondary requirement to marked-as-decorative rule * Update _rules/element-marked-decorative-is-not-exposed-46ca7f.md --------- Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
…l property is allowed except when prohibited and added examples (#2192) * Update aria-state-or-property-permitted-5c01ea.md * Update aria-state-or-property-permitted-5c01ea.md * Update aria-state-or-property-permitted-5c01ea.md * Update spelling-ignore.yml added superclass * Apply suggestions from code review --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
* Direct Netlify setup for PR preview deploys * Update netlify.toml
Bumps [undici](https://github.com/nodejs/undici) from 5.28.4 to 5.28.5. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.4...v5.28.5) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…xample 1 and adds accessibility support note to cover SVG role exposed differently by browsers (#2290) * Add accessibility support note to cover SVG elements role inconsistently exposed * Update _rules/image-non-empty-accessible-name-23a2a8.md Co-authored-by: Kevin White <kevin@w3.org> * added SvgRoot term * Apply suggestions from code review * Update _rules/image-non-empty-accessible-name-23a2a8.md --------- Co-authored-by: Kevin White <kevin@w3.org>
…ample 3 improvement (#2251) * Update aria-required-owned-element-bc4a75.md * Update _rules/aria-required-owned-element-bc4a75.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> --------- Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
…o cells in the same table element - Inapplicable Example 4 improvement (#2244) * Added aria-label to the role="table" element * Update _rules/table-headers-attribute-refer-to-data-cells-a25f45.md Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com> --------- Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
* Editorial update iframe focusable * Add 2.1.3
* . * Update _rules/zoom-text-no-overflow-clipping-59br37.md Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * passed example 3: duplicating suggestion by wilco in 5fa4526 --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
Noticed this one reviewing our support items. This looks like it might have been added by some misunderstanding on our part, not something that was a problem in browsers. The issue here related to form elements with autocomplete=off, but as far as I can tell that does not result in `elm.autocomplete === ''` when the autocomplete is otherwise set.
* button name move assumption to the correct section * Update button-non-empty-accessible-name-97a4e1.md * Update button-non-empty-accessible-name-97a4e1.md
* summary name, element position clarified * fix link
* Updates process * Fix heading level * Update pages/design/process.md Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> --------- Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…uired states and properties" rule (#2328) * fix aria mapping * remove comment
Bumps [undici](https://github.com/nodejs/undici) from 5.28.5 to 5.29.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.5...v5.29.0) --- updated-dependencies: - dependency-name: undici dependency-version: 5.29.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…decorative SVG examples + Accessibility support notes (#2321) * Update image-not-in-acc-tree-is-decorative-e88epe.md * Update image-not-in-acc-tree-is-decorative-e88epe.md * Update image-not-in-acc-tree-is-decorative-e88epe.md
… 307n5z) - adding examples (#2099) * invalid-form-field-value-36b590: updating failed example 2. * Adding examples to rule presentational-children-no-focusable-content-307n5z * Update _rules/presentational-children-no-focusable-content-307n5z.md * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com> * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com> * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com> * Inapplicable Example 4: - reducing verbosity. - removing most commentary on "hidden" vs. "presentational". - removing all commentary on "marked as decorative". * Updating Inapplicable Example 4 and references to rule 6cfa84. * Updating Inapplicable Example 1 because of #2099 (comment) * updating Inapplicable Example 2 based on #2099 (comment) * removing Inapplicable Example 3 and replacing it w/ wording in the "background" section. in response to #2099 (comment) * updating Background in response to #2099 (comment) * Updating "Inapplicable Example 1" as per https://github.com/act-rules/act-rules.github.io/pull/2099/files#r1426483648 * Inapplicable Example 1: fixing whitespace. * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/presentational-children-no-focusable-content-307n5z.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> --------- Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
…ts` (#2329) * fix aria mapping * remove comment * add test for aria properties * remove title and only * remove title and only * remove title and only * add one more property * update test * remove only
…with implicit roles (#2318) * update the examples for aria-required-owned rule * update the test cases * fix syntax errors * remove implicit/explicit from the description Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * add more Pass and Fail test cases * fix formatting issue * add more test cases * update the test cases * remove unused explcit_semantic_role * Add one more Failed example --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* Update aria-hidden-no-focusable-content-6cfa84.md * Update aria-hidden-no-focusable-content-6cfa84.md
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update envo