[9.0][IMP] pos_payment_terminal_server: take into account changes in …#4
Open
rousseldenis wants to merge 4 commits into9.0-add_pos_payment_terminal_server-drofrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## 9.0-add_pos_payment_terminal_server-dro #4 +/- ##
========================================================================
Coverage 56.38% 56.38%
========================================================================
Files 21 21
Lines 282 282
========================================================================
Hits 159 159
Misses 123 123Continue to review full report at Codecov.
|
rousseldenis
force-pushed
the
9.0-imp-pos_payment_terminal-server-dro
branch
from
d4cedfa to
bd745ef
Compare
rousseldenis
force-pushed
the
9.0-imp-pos_payment_terminal-server-dro
branch
from
bd745ef to
03376d6
Compare
apineux
reviewed
Nov 14, 2019
Comment on lines
+45
to
+47
| var res = _paymentlineproto.is_payment_terminal_driven.apply(this, arguments); | ||
| res = self.cashregister.journal.payment_mode && self.pos.config.use_payment_terminal_server; | ||
| return res; |
There was a problem hiding this comment.
Just return self.cashregister.journal.payment_mode && self.pos.config.use_payment_terminal_server;
| this._super.apply(this, arguments); | ||
| if (this.pos.config.iface_payment_terminal_server){ | ||
| var self = this; | ||
| this.$('.paymentlines-container').unbind('click').on('click', '.payment-terminal-transaction-start', function(event){ |
There was a problem hiding this comment.
Did you forget to call "start_transaction"? If not then clean this method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ppt module
Depends on :