ACMS-6125:Clear Facet Filters block not rendering in Query String URL…#1986
Open
rohansinhadev wants to merge 2 commits into
Open
ACMS-6125:Clear Facet Filters block not rendering in Query String URL…#1986rohansinhadev wants to merge 2 commits into
rohansinhadev wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the “Clear Facet Filters” block so it renders a “Clear filter(s)” link when facets are using the Query String URL processor (not only Pretty Paths), aligning behavior across facet URL processor modes.
Changes:
- Treat Pretty Paths as facets encoded in the
facets_queryroute parameter and generate a clear link accordingly. - Add Query String handling by detecting the
fquery parameter and generating a clear link withfremoved from the query string.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… processor mode
Motivation
The "Clear Facet Filters" block only renders when the facet source uses the Pretty Paths URL processor. When switched to the default Query String processor, the block returns empty and the "Clear filter(s)" link never appears.
Fixes #NNN
Proposed changes
Alternatives considered
Testing steps
Add the "Clear Facet Filters" block to a Site Studio View and keep Query String processor in facets, the Clear Facet Filters will work after these changes.
Merge requirements