This repository was archived by the owner on Aug 3, 2025. It is now read-only.
Add group chair contact info to meetings panel#25
Open
benpankow wants to merge 4 commits intoacm-uiuc:masterfrom
Open
Add group chair contact info to meetings panel#25benpankow wants to merge 4 commits intoacm-uiuc:masterfrom
benpankow wants to merge 4 commits intoacm-uiuc:masterfrom
Conversation
bcongdon
suggested changes
Sep 11, 2017
| <td>{fulltime}</td> | ||
| </tr>; | ||
| if (displayingMeetings) { | ||
| var location = meeting.meetingLoc ? meeting.meetingLoc : 'TBA'; |
Member
There was a problem hiding this comment.
Location, meeting_time, meeting_date, and fulltime can be calculated outside the if/else block
Author
There was a problem hiding this comment.
I removed them from the else block since they weren't used there - I can move them and the chair stuff outside the if/else, but then they would be calculated where they're not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires acm-uiuc/groot-groups-store#43.
Adds contact info for ACM group chairs to the meetings panel. After a slide with meeting information, the chair name and contact information for those groups are displayed.