Fix '--color always' option when not stdout output #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: If not stdout, program will auto-detect terminfo capabilities despite the choice regarding the `--color` command line argument. Because of this, terminfo terminal is never initialized and the program breaks when trying to output any color code. This change forces terminfo proper initialization if `--color always` is requested, even if `os.isatty()` is `False`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
If not stdout, program will auto-detect terminfo capabilities despite the choice regarding the
--colorcommand line argument. Because of this, terminfo terminal is never initialized and the program breaks when trying to output any color code.Proposed solution
This change forces terminfo proper initialization if
--color alwaysis requested, even ifos.isatty()isFalse.