Skip to content

Refine the implementation of __clean_messages(). #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdSchouten wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refine the implementation of __clean_messages(). #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f1e807
Refine the implementation of __clean_messages().
Oct 15, 2018
db7c6a2
Also suppress the useless multiply-defined labels warning.
Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions latexrun
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,18 +965,23 @@ class LaTeX(Task):

def __clean_messages(self, msgs):
"""Make some standard log messages more user-friendly."""
have_undefined_reference = False
has_errors = any(msg.typ == 'error' for msg in msgs)
for msg in msgs:
if msg.msg == '==> Fatal error occurred, no output PDF file produced!':
msg = msg._replace(typ='info',
msg='Fatal error (no output file produced)')
if msg.msg.startswith('[LaTeX] '):
# Strip unnecessary package name
msg = msg._replace(msg=msg.msg.split(' ', 1)[1])
if re.match(r'Reference .* undefined', msg.msg):
have_undefined_reference = True
if have_undefined_reference and \
re.match(r'There were undefined references', msg.msg):
if has_errors and re.match(
r'.*[Rr]erun to get .* right|.* on page .* undefined', msg.msg
):
# Warnings on undefined references may occur in high
# numbers when documents fail to build.
continue
if re.match(
r"There were (multiply-defined labels|undefined references)", msg.msg
):
# LaTeX prints this at the end so the user knows it's
# worthwhile looking back at the log. Since latexrun
# makes the earlier messages obvious, this is
Expand Down