Added Docker support for template-engine#34
Closed
superAman07 wants to merge 2 commits intoaccordproject:mainfrom
Closed
Added Docker support for template-engine#34superAman07 wants to merge 2 commits intoaccordproject:mainfrom
superAman07 wants to merge 2 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: superAman07 <rivalaman123@gmail.com>
Member
|
@dselman do we have a requirement for this? |
Contributor
|
Sounds useful, yes. |
sanketshevkar
approved these changes
Feb 26, 2025
Member
|
@dselman can you please review this once as well. |
mttrbrts
reviewed
Mar 29, 2025
Member
mttrbrts
left a comment
mttrbrts
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @superAman07!
I'm curious, what is the API / interface for using the image? i.e. how do we make this useful for users?
Are you also able to add a step in the build workflow to test the docker build, please?
Author
|
@mttrbrts , I’ve added detailed instructions in the README.md file on how to build and use the Docker image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Docker support for the project. This includes a Dockerfile that sets up a lightweight Node.js environment using Alpine, installs dependencies, builds the TypeScript project, and runs the application from the dist folder. Future enhancements like .env support or database integration can be added as needed.