This repository was archived by the owner on May 19, 2020. It is now read-only.
feat(hyperlink modal): added message for successful copy of a link url#391
Open
nik72619c wants to merge 1 commit intoaccordproject:masterfrom
Open
feat(hyperlink modal): added message for successful copy of a link url#391nik72619c wants to merge 1 commit intoaccordproject:masterfrom
nik72619c wants to merge 1 commit intoaccordproject:masterfrom
Conversation
Signed-off-by: Nikhil <nikhilsharmarockstar21@gmail.com>
dbe4241 to
3c55902
Compare
Contributor
Author
|
@DianaLease @irmerk @Michael-Grover please have a look :) |
Contributor
Author
|
thanks for the review @Michael-Grover . Making the changes ! |
Contributor
|
@nik72619c If I copy a link once. The message will show. If I then change the link to some other value, and then try to copy it again in the same modal,the message still stays up and there would be no way for me to know that the new link was copied correctly or not. Can we make |
Member
|
We're migrating this repository into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Signed-off-by: Nikhil nikhilsharmarockstar21@gmail.com
Issue #379
Changes