GUI: standardize action button labels by changing "New..." to "Add..."

[AAClause]

• Changed button labels from "&New..." to "&Add..." to maintain consistency with other action buttons that use verbs (e.g., Edit and Delete), and to prevent translation complications related to gender, such as "nouveau" and "nouvelle" in French.
• Updated the description hint for empty lists in the Criteria Editor from "Press alt+n" to "Press Alt+A."
• Modified the label for alternatives from "&Alternatives" to "A&lternatives" to avoid conflict with the "&Add" shortcut key.
• Renamed the event handler from onNewCriteria to onAddCriteria for better alignment.

[JulienCochuyt]

@AAClause wrote:

consistency with other action buttons that use verbs (e.g., Edit and Delete),

I agree this is an outrageous lexical discrepancy, but we - my fellow wordsmith - have lost this war in the early 80s.
Have a look at the two first entries in any standard "File" menu…

and to prevent translation complications related to gender, such as "nouveau" and "nouvelle" in French.

I would advocate pgettext is the preferred way to go in such case.
In the very case your pointing out, I tend to refer to this list as containing "Alternative Criteria Sets", which translates to "Jeux de critères alternatifs" which is of masculine grammar gender.

Hence, -1 for me.

[AAClause]

@JulienCochuyt Yes but... the NVDA codebase tends to favor the term "Add" over "New".

nvda/source/gui$ grep -ri -E "['\"]&(add|new)['\"]" --include='*.py' .
./configProfiles.py:            newButton = buttonHelper.addButton(profilesListBox, label=_("&New"))
./inputGestures.py:             self.addButton = bHelper.addButton(self, label=_("&Add"))
./settingsDialogs.py:           addButton = bHelper.addButton(self, label=_("&Add"))
./speechDict.py:                        label=_("&Add")

@frederic-brugnot We'd love to hear your thoughts to help settle this discussion! 😀