Skip to content

final#32

Open
bblanco1 wants to merge 1 commit intoaccesscode-2-2:masterfrom
bblanco1:master
Open

final#32
bblanco1 wants to merge 1 commit intoaccesscode-2-2:masterfrom
bblanco1:master

Conversation

@bblanco1
Copy link

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: there should be a space between the property attributes and the type

@property(nonatomic) CQCategory *category;
//                  ^

@cspickert
Copy link

Looks great overall! I think this is the right architecture. Style-wise, make sure to keep your vertical and horizontal spacing consistent, and think about removing the default/empty method implementations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments here. First, when you're overriding methods like viewDidLoad or viewDidAppear:, you should always call the super implementation first:

[super viewDidAppear:animated];
//...

That way, you'll run the code in the superclass's implementation of this method, and then your code.

Second, you probably noticed that after you select an option in the detail view and then go back, there's a delay before any changes are reflected in the master table view. If you wanted the change to be more instantaneous, you could create a delegate property on your detail view controller and set it to self when preparing to segue from the master to the detail controller, and send a message to the master controller whenever an option was selected indicating that it should reload its table view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants