KPicart-HW4

[krishnaC4]

No description provided.

[tannerwelsh]

Like the custom initializer method. :D

[tannerwelsh]

Overall, nice work @krishnapicart. Your code is clear, generally expressive, and well organized. Looks like you went beyond the scope of the homework too, glad to see that you were able to get creative with it. 😄

Some thoughts:

• Nice job separating concerns and organizing your code. 👍
• In the future, avoid committing unused files (e.g. xTableViewController.h)
• If you make commits as you go, it helps show the progress of your thinking and provides good fallback points in case you need to change something. More small commits > a few big commits.
• Consider using delegation to send messages from the edit view back to the index view. This seems to be the accepted way to send messages between two view controllers (although maybe @mikekavouras has some better insight here).
• Try to avoid committing too much extra whitespace (2 blank lines or more is usually too much) and any unused (incl. commented-out) code. Since this is just "noise", it only clutters up your files.

[krishnaC4]

Hey T- thx for the smackDown!

 

lol-- the work is based off a video tutorial series i found
when I felt a need to expand off the base concepts of the homework. 

 

1. The intermediate embed In nav controller is used as a way to
   get a nav controller bar into the "add item" table VC, so I could use
   a title and some bar buttons.

 

2. The index naming convention is what the app will be: a full
   index of all the iOS Objects and definitions, i'm hoping Apple has an API for
   that.

 

Your review was helpful and I will be implementing your
suggestions.

Hey T- thx for the smackDown! lol-- the work is based off a video tutorial series i found
when I felt a need to expand off the base concepts of the homework.   The intermediate embed In nav controller is used as a way to
get a nav controller bar into the "add item" table VC, so I could use
a title and some bar buttons. The index naming convention is what the app will be: a full
index of all the iOS Objects and definitions, i'm hoping Apple has an API for
that. 

Your review was helpful and I will be implementing your
suggestions.

-------- Original Message --------
Subject: Re: [unit-1-hw-week-4] KPicart-HW4 (#18)
From: Tanner Welsh notifications@github.com
Date: Mon, August 17, 2015 4:39 pm
To: accesscode-2-2/unit-1-hw-week-4
unit-1-hw-week-4@noreply.github.com
Cc: Krishna c4q@javaworkgroup.com

Overall, nice work @krishnapicart. Your code is clear, generally expressive, and well organized. Looks like you went beyond the scope of the homework too, glad to see that you were able to get creative with it. Some thoughts: Nice job separating concerns and organizing your code. In the future, avoid committing unused files (e.g. xTableViewController.h) If you make commits as you go, it helps show the progress of your thinking and provides good fallback points in case you need to change something. More small commits > a few big commits. Consider using delegation to send messages from the edit view back to the index view. This seems to be the accepted way to send messages between two view controllers (although maybe @mikekavouras has some better insight here). Try to avoid committing too much extra whitespace (2 blank lines or more is usually too much) and any unused (incl. commented-out) code. Since this is just "noise", it only clutters up your files. —Reply to this email directly or view it on GitHub.

[tannerwelsh]

Haha, no, not a smackdown. Constructive criticism! At least, that's how I intended, hope it came off that way. You're off to good start!

[krishnaC4]

thx  TYour comments were really well received, i jst can't resist a good joke...and The "smackDown" piece was TOO good 2 pass up.  i'll try to refrain from such deviations in the future.catch u later!krishna 

-------- Original Message --------
Subject: Re: [unit-1-hw-week-4] KPicart-HW4 (#18)
From: Tanner Welsh notifications@github.com
Date: Tue, August 18, 2015 8:22 am
To: accesscode-2-2/unit-1-hw-week-4
unit-1-hw-week-4@noreply.github.com
Cc: Krishna c4q@javaworkgroup.com

Haha, no, not a smackdown. Constructive criticism! At least, that's how I intended, hope it came off that way. You're off to good start! —Reply to this email directly or view it on GitHub.