Skip to content

Week 2 HW - Henna#20

Open
xhenna92 wants to merge 5 commits intoaccesscode-2-2:masterfrom
xhenna92:master
Open

Week 2 HW - Henna#20
xhenna92 wants to merge 5 commits intoaccesscode-2-2:masterfrom
xhenna92:master

Conversation

@xhenna92
Copy link

No description provided.

@xhenna92 xhenna92 changed the title Initial pull request Week 2 HW - Henna Jun 23, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is technically correct, however, it can be optimized into a single loop:

    for (int i = 1; i<25; i++) {
            NSString * decoded2 = [self decode:string2 offset:i];
            if ([string1 isEqualToString:decoded2]) {
                return YES;
            }
    }

    return NO;

The difference is wost case 25 iterations vs. worst case 600+ iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants