-
Notifications
You must be signed in to change notification settings - Fork 0
Bump to vue 3 #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Bump to vue 3 #1293
Changes from all commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
9a5770d
Update packages, basic configuration
chvp d702728
Fix all lint errors
chvp 629bd94
Fix compilation
chvp d9d5043
Use Promise.withResolvers()
chvp 9572dfb
Fix errors always rendering
chvp 1db3428
Add back catch-all path
chvp fa263d4
Replace all activator on usages with props
chvp b01ae51
Use item.raw in default template for data iterator
chvp ef670d5
Make tables render something
chvp 3d85285
Update vuedraggable and fix usages
chvp d345b41
Bring back pagination on the homepage
chvp 30ae482
Bring back title updates using unhead
chvp ba0ebd1
Fix layout of navigation drawer
chvp 8b929f2
Fix image picker
chvp cbeb321
Fix artist card not cropping images
chvp a7a1345
Follow system theme
chvp 3ebdb72
Re-introduce vuetify scss settings
chvp 5feb46a
Use primary color for all links by default
chvp d0a8f26
Stop using non-existent colors
chvp 5ff8b1e
Make sure on this day albums are sorted newest first
chvp 559a4f3
Fix usages of display-breakpoints
chvp 65ed89d
Make sure footer background isn't white in dark mode
chvp cc20f54
Fix layout and behaviour of sliders in player
chvp a3de53e
Remove some unused styling
chvp 4847681
Fix intersection calculation in stats
chvp c22fb2c
Fix period picker in stats
chvp 7cd4b3d
Fix layout of range picker card
chvp 40f3d68
Set minimum width of period picker
chvp bdd7a2a
Fix playlist form
chvp 8932e02
Use camelcase style component for VTable
chvp 7be469c
Fix styling of some icon buttons
chvp ba9e750
Fix id append of album selector in track form
chvp 9a4e58d
Fix lint
chvp b69470b
Use translations from vuetify to fix a lot of missing translation war…
chvp 9cd3a38
Fix some styling on the homepage
chvp 6e9325a
Fix pagination on artists page
chvp e428168
Fix amount of items in rows on the home page
chvp a5a568a
Enlarge icons in the action buttons
chvp 31d0546
Fix lint
chvp e94a066
Fix the size of some more action icons
chvp 0500b1d
Fix the size of some more action icons
chvp d164b51
Add pagination to albums page
chvp ac5d0d2
Fix multi-delete in auth tokens table
chvp 1479ee0
Fix removeItem when some ids are strings
chvp 63a4bde
Fix some more icon sizes in actions
chvp 40179d8
Fix icon sizes on users index
chvp 279e870
Fix pagination on genres, labels and playlists
chvp 759f599
Fix look and functionality of user settings
chvp 9d5d26e
Fix artist form
chvp a9050c2
Fix album form
chvp 13b897e
Fix merge dialogs
chvp 3dfaefb
Fix tracks table look and interactions
chvp d9bf7de
Add custom footer to auth tokens table
chvp 3385369
Make pagination compact
chvp 7523868
Add pagination to label and playlist show
chvp 8e9865b
Fix layout of merge track view
chvp f8ea1f1
Fix loading of some pages
chvp bca8f47
Fix track form
chvp a74ab60
Fix styling of mass edit
chvp cb70c0c
More styling fixes
chvp c839472
Even more styling fixes
chvp 01b3606
Fix selectability of current auth token
chvp 7f78a0b
Fix text color in stats
chvp 84492bb
Fix percentage played text color in stats
chvp f7f3217
Fix height of average switch in stats
chvp 955e715
Fix some usages of `:value`
chvp 2a3f787
Remove explicit dependency on sfc compiler
chvp 1694f18
Configure vue-eslint-parser, lint
chvp 0aa930e
Lint tool config files as well
chvp ad732ff
Restore accidently removed rules
chvp e64e295
Convert app to typescript and composition API
chvp ee49319
Remove some more non-composition API usages
chvp b954648
Remove type cast for vuetify vue-i18n integration
chvp 8acb011
Fix new plays not having a time
chvp 5ed2b19
Fix review comments not being cleared
chvp 383c96c
Fix tracks disappearing after artist merge
chvp c03f746
Fix track numbers to be number fields
chvp 6adb33c
Fix album selection in mass edit dialog
chvp 8f654d3
Introduce helper type for models enhanced with loaded timestamp
chvp b77fc35
Rename date modal models in album form
chvp 9eb8196
Fix sorting of dates in range select
chvp cf26833
Fix sorting of artists in top albums list
chvp 1c529bb
Make sure tracks table actually uses save pagination prop
chvp 43c97f4
Don't allow exception for higher order functions in eslint
chvp 00122a1
Require promises to be handled
chvp f19ea0a
Move comparators to util
chvp abd5e84
Don't make previous and next items small
chvp 038474b
Align pagination to the right
chvp f67376c
Set list icon item opacity to 1
chvp 41e88e0
Remove arrow key handling in track form artists
chvp 063832d
Bump api-client-js dependency
chvp 31e9125
Update yarn.nix
chvp 330c382
Fix type in Login.vue
chvp eb17f02
Don't typecheck eslint config
chvp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // This is defined by vite at build time | ||
| declare let __APPLICATION_VERSION__: string; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { globalIgnores } from "eslint/config"; | ||
| import eslint from "@eslint/js"; | ||
| import tseslint from "typescript-eslint"; | ||
| import globals from "globals"; | ||
| import prettier from "@vue/eslint-config-prettier"; | ||
| import vue from "eslint-plugin-vue"; | ||
| import vueParser from "vue-eslint-parser"; | ||
| import vuetify from "eslint-plugin-vuetify"; | ||
| import { | ||
| defineConfigWithVueTs, | ||
| vueTsConfigs, | ||
| } from "@vue/eslint-config-typescript"; | ||
|
|
||
| export default defineConfigWithVueTs( | ||
| { | ||
| name: "app/files-to-lint", | ||
| files: ["**/*.{vue,ts}"], | ||
| }, | ||
| globalIgnores(["**/dist/**", "eslint.config.ts"]), | ||
| eslint.configs.recommended, | ||
| { | ||
| files: ["**/*.vue"], | ||
| languageOptions: { | ||
| parser: vueParser, | ||
| }, | ||
| }, | ||
| tseslint.configs.strict, | ||
| tseslint.configs.stylistic, | ||
| ...vue.configs["flat/recommended"], | ||
| ...vuetify.configs["flat/recommended"], | ||
| vueTsConfigs.recommended, | ||
| prettier, | ||
| { | ||
| rules: { | ||
| curly: "error", | ||
| "no-console": "error", | ||
| "no-debugger": "error", | ||
| "no-invalid-this": "error", | ||
| "require-await": "error", | ||
| "vue/multi-word-component-names": "off", | ||
| "@typescript-eslint/explicit-function-return-type": [ | ||
| "error", | ||
| { allowHigherOrderFunctions: false }, | ||
| ], | ||
| "@typescript-eslint/explicit-module-boundary-types": "error", | ||
| "@typescript-eslint/no-floating-promises": "error", | ||
| "@typescript-eslint/no-non-null-assertion": "off", | ||
| }, | ||
| languageOptions: { | ||
| sourceType: "module", | ||
| globals: { | ||
| ...globals.browser, | ||
| }, | ||
| }, | ||
| }, | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| @use "vuetify/settings" with ( | ||
| $button-text-letter-spacing: 0, | ||
| $list-item-icon-opacity: 1, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,72 +1,37 @@ | ||
| <template> | ||
| <VApp> | ||
| <router-view /> | ||
| <Suspense> | ||
| <RouterView /> | ||
| <template #fallback> | ||
| <VIcon>mdi-refresh mdi-spin</VIcon> | ||
| </template> | ||
| </Suspense> | ||
| </VApp> | ||
| </template> | ||
|
|
||
| <script> | ||
| export default { | ||
| name: "Root", | ||
| metaInfo: { | ||
| title: "Main", | ||
| titleTemplate: "%s | Accentor", | ||
| }, | ||
| }; | ||
| <script setup lang="ts"> | ||
| import { useHead } from "@unhead/vue"; | ||
|
|
||
| useHead({ title: "Main" }); | ||
| </script> | ||
|
|
||
| <style lang="scss"> | ||
| @import "vuetify/src/styles/styles.sass"; | ||
|
|
||
| // Additional resets | ||
| a { | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| // Component styles with global scope | ||
| .actions { | ||
| .actions__button { | ||
| margin: 4px 8px 4px 0; | ||
| } | ||
| } | ||
| .actions--wide { | ||
| .actions__button { | ||
| margin: 8px 16px 8px 0; | ||
| } | ||
| } | ||
|
|
||
| @media (min-width: map-get($grid-breakpoints, "sm")) { | ||
| .actions--sm-wide { | ||
| .actions__button { | ||
| margin: 8px 16px 8px 0; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .button-group { | ||
| border-radius: 4px; | ||
| overflow: hidden; | ||
| box-shadow: | ||
| 0px 2px 4px -1px rgba(0, 0, 0, 0.2), | ||
| 0px 4px 5px 0px rgba(0, 0, 0, 0.14), | ||
| 0px 1px 10px 0px rgba(0, 0, 0, 0.12); | ||
|
|
||
| &__button { | ||
| margin: 0; | ||
| border-radius: 0; | ||
| } | ||
| color: rgb(var(--v-theme-primary)); | ||
| } | ||
|
|
||
| // Additional utility classes | ||
| .break-word { | ||
| word-break: break-word; | ||
| } | ||
|
|
||
| .white-space-nowrap { | ||
| white-space: nowrap; | ||
| .no-break-word { | ||
| word-break: keep-all; | ||
| } | ||
|
|
||
| // Temporary fix until https://github.com/vuetifyjs/vuetify/issues/13678 is resolved | ||
| .v-data-footer { | ||
| justify-content: flex-end; | ||
| .white-space-nowrap { | ||
| white-space: nowrap; | ||
| } | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.