Cleanup#137
Merged
Merged
Conversation
Fix the workspace build (framed_to_adder_hd.rs bench used removed Framed/SimulProcArgs/SimulProcessor APIs from the arithmetic-coding refactor). Remove dead code surfaced by clippy: the entirely-unused d_controller module, ~390 lines of commented-out Bevy-era UI in adder-viz, unused struct fields/test helpers, and panic/todo! trait impls kept only to satisfy bounds. Fix clippy warnings (unused vars/imports, swallowed Results, a vec![x; n] pattern that silently dropped Vec capacity) and strip stray dbg!/eprintln! debug leftovers, including one firing every frame in a hot path. Performance: replace a linear D_SHIFT scan in the per-event pixel integration path with a leading_zeros()-based bit-length lookup, preallocate a 3D pixel buffer instead of growing it via nested push(), and write DVS text events directly instead of building an intermediate String per event. All existing tests pass; cargo fmt and clippy are clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.