Skip to content

Drop imghdr from Notes artifact#1488

Draft
Mirochill wants to merge 1 commit into
abrignoni:mainfrom
Mirochill:fix-1246-drop-imghdr
Draft

Drop imghdr from Notes artifact#1488
Mirochill wants to merge 1 commit into
abrignoni:mainfrom
Mirochill:fix-1246-drop-imghdr

Conversation

@Mirochill
Copy link
Copy Markdown

Closes #1246.
Closes #1321.

Summary:

  • Replace the Notes artifact's deprecated imghdr.what() checks with the existing scripts.filetype.image_match helper.
  • Keep thumbnail creation limited to JPEG/PNG attachments while avoiding the removed stdlib imghdr module.

Validation:

  • git diff --check
  • rg -n "\bimghdr\b|imghdr\.what" . --glob "!*.ipynb"
  • Not run locally: tests/build/lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

standard-imghdr missing Make "standard-imghdr" a requirement for Python 3.13 compatibility

1 participant