Skip to content

Conversation

@Dedsec0098
Copy link

Fix #1798

Changes Made:

  1. I have removed paginated ( ) and have added interator ( ) to improve the performance in terms of compute time and memory usage.
  2. Removed per_page parameter as Django's built-in .iterator() doesn't accept this parameter.

@keshav-space I have made the changes according to the issue and it is passing all the tests on my local system, however I am not sure how to exactly run the iterations for advisories to check the new response time can you please suggest me on how can I run those and also If you have any suggestions please let me know I will make the changes required.

Signed-off-by: Shrish0098 <shrish409@gmail.com>
@Dedsec0098 Dedsec0098 changed the title Fix: Removing custom paginated and added iterator Fix: Removed custom paginated and added iterator Mar 8, 2025
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dedsec0098, use the appropriate chunk size in the iterator and also remove the paginated from our base queryset manager.

@Dedsec0098
Copy link
Author

Sure, I'll start making the changes required

…l.com

Signed-off-by: Shrish0098 <shrish409@gmail.com>
@Dedsec0098
Copy link
Author

Hey @keshav-space I have made the changes you asked, please let me know if any further changes are required.

@keshav-space keshav-space added the vibe-code Completely AI-generated code label Mar 20, 2025
@pombredanne
Copy link
Member

Thanks.
This is not actionable until tested. If you are able to submit code that is minimally tested and does run and is not AI generated, come back, but only then.
I am going to close all your other PRs for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vibe-code Completely AI-generated code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of the custom paginated() and use the built-in iterator()

3 participants