Skip to content

Implement Descending Sorting for Packages and Vulnerabilities in API and UI#1758

Open
NucleonGodX wants to merge 4 commits intoaboutcode-org:mainfrom
NucleonGodX:latest-api-ui
Open

Implement Descending Sorting for Packages and Vulnerabilities in API and UI#1758
NucleonGodX wants to merge 4 commits intoaboutcode-org:mainfrom
NucleonGodX:latest-api-ui

Conversation

@NucleonGodX
Copy link

@NucleonGodX NucleonGodX commented Jan 23, 2025

#1754
image
image

Used aliases to sort vulnerabilities in descending order and implemented version-based sorting for packages in both the API and UI.

@NucleonGodX NucleonGodX changed the title initial changes web and apis working Implement Descending Sorting for Packages and Vulnerabilities in API and UI Jan 23, 2025
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
@pombredanne
Copy link
Member

Thanks! do you mind to add some tests?

In particular we need to make sure that this does not impact performance badly so the perf there at scale need to be in a test.

NucleonGodX and others added 2 commits January 24, 2025 21:53
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
@NucleonGodX
Copy link
Author

Thanks! do you mind to add some tests?

In particular we need to make sure that this does not impact performance badly so the perf there at scale need to be in a test.

Hey @pombredanne, How can we perform those tests?

@Dedsec0098
Copy link

Hey @NucleonGodX , I think @pombredanne wants you to add "Unit Test" for your changes. To make those unit tests you need to make a new test file at vulnerabilities/tests for your specific test for example as said above "to make sure that this does not impact performance badly".

@TG1999
Copy link
Contributor

TG1999 commented Apr 18, 2025

@NucleonGodX a gentle reminder, is this PR active ?

@NucleonGodX
Copy link
Author

Hi @TG1999, actually when I opened this PR, I discussed this with @keshav-space in the weekly meet regarding the performance test cases, and he informed me that they aren't necessarily required, so I didn't add anything else in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants