Skip to content

Conversation

@unibik
Copy link

@unibik unibik commented Jan 15, 2025

issue #517 Added separate tests for docker .
Now both test environment and docker containers runs on ubuntu-latest

Signed-off-by: Arshad <arshad.chotu10@gmail.com>
Django==4.2.17
django-crispy-forms==2.3
django-environ==0.11.2
django-extensions==3.2.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this ?

Signed-off-by: Arshad <arshad.chotu10@gmail.com>
@unibik unibik force-pushed the feature/update-workflow branch from 8c034f9 to dea5ae4 Compare January 17, 2025 06:28
@unibik
Copy link
Author

unibik commented Feb 13, 2025

Hello @TG1999 ,i ran the above test in my local machine using the tool called act tool,It showed no errors , so can you please review it once , if it fails again . It would be helpful if you suggest me why the test is failing here . Thank you

@TG1999
Copy link
Contributor

TG1999 commented Apr 18, 2025

@unibik please explain the changes in requirements.txt

@unibik
Copy link
Author

unibik commented Apr 19, 2025

Hello, @TG1999 While testing the Docker-based CI pipeline locally using the act tool, I encountered a ModuleNotFoundError for some dependencies like cvss, django-extensions, and htmllistparse. These modules were used in the codebase but weren’t listed in the requirements.txt file.
As the docker tests use the command docker compose build --no-cache, which will create a new image which doesn't include the modules present in the host or owners machine. So I explicitly added those module.
Thank you for reviewing my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants