Skip to content

Fix crash in assemble_package when manifest is at codebase root #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kaushik-Kumar-CEG wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix crash in assemble_package when manifest is at codebase root #2070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions scanpipe/pipes/scancode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,16 +619,22 @@ def assemble_package(resource, project, processed_paths):
package_adder=add_resource_to_package,
)

for item in extracted_items:
logger.info(f" Processing item: {item}")
if isinstance(item, packagedcode_models.Package):
pipes.update_or_create_package(project, item.to_dict())
elif isinstance(item, packagedcode_models.Dependency):
pipes.update_or_create_dependency(project, item.to_dict())
elif isinstance(item, CodebaseResource):
processed_paths.add(item.path)
else:
logger.info(f"Unknown Package assembly item type: {item!r}")
try:
for item in extracted_items:
logger.info(f" Processing item: {item}")
if isinstance(item, packagedcode_models.Package):
pipes.update_or_create_package(project, item.to_dict())
elif isinstance(item, packagedcode_models.Dependency):
pipes.update_or_create_dependency(project, item.to_dict())
elif isinstance(item, CodebaseResource):
processed_paths.add(item.path)
else:
logger.info(f"Unknown Package assembly item type: {item!r}")
except AttributeError as e:
# Occurs when the handler cannot resolve a parent resource,
# e.g. a manifest at the root of the codebase with no parent path.
logger.warning(f" Package assembly skipped for {resource.path}: {e}")
logger.debug("", exc_info=True)


def process_package_data(project, static_resolve=False):
Expand Down