Skip to content

Add MIT rule variant with attribution and no-endorsement clause#4721

Open
dikshaa2909 wants to merge 6 commits intoaboutcode-org:developfrom
dikshaa2909:add-mit-attribution-no-endorsement
Open

Add MIT rule variant with attribution and no-endorsement clause#4721
dikshaa2909 wants to merge 6 commits intoaboutcode-org:developfrom
dikshaa2909:add-mit-attribution-no-endorsement

Conversation

@dikshaa2909
Copy link

@dikshaa2909 dikshaa2909 commented Feb 2, 2026

Fixes #4719

Summary

This PR adds a new MIT license rule variant that includes an explicit
attribution requirement and a no-endorsement clause, as used by
Sinusoidal Systems AB.

The rule follows existing ScanCode license rule conventions and does not
introduce any code or logic changes.

Details

  • Added a new MIT license rule covering attribution + no-endorsement language
  • Rule text matches the upstream license wording used by Sinusoidal Systems AB
  • Curly-brace markers ({{ }}) are used only inside the license text body,
    consistent with existing MIT rules in the repository
  • No required_phrases metadata is used, in line with similar MIT rules

Testing

  • CI tests executed via GitHub Actions
  • License validation and related tests pass

Signed-off-by: Diksha Deware dikshadeware@gmail.com

Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
@dikshaa2909 dikshaa2909 force-pushed the add-mit-attribution-no-endorsement branch from 3794879 to 5ac7c1d Compare February 2, 2026 13:41
@dikshaa2909 dikshaa2909 changed the title Add MIT license rule with attribution and no-endorsement clause Add MIT rule variant with attribution and no-endorsement clause Feb 2, 2026
@dikshaa2909
Copy link
Author

The CI failures are due to workflows awaiting maintainer approval
since this PR is from a fork. No functional changes beyond adding
the new license detection rule.

Happy to update if any adjustments are needed.

@AyanSinhaMahapatra
Copy link
Member

This is not how required phrases are added, please check other rules for examples. We use curly brackets {{ <required phrase> }} to mark this. All your tests are failing because of this, please run tests locally before you add a PR, or look into the CI failures and fix this after opening a PR.

You are also not using the PR template which asks you to fix the tests etc, check contributing to see what you need to follow

@AyanSinhaMahapatra AyanSinhaMahapatra added the need-changes PR needs to be updated with feedback label Feb 3, 2026
Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
@dikshaa2909 dikshaa2909 force-pushed the add-mit-attribution-no-endorsement branch from 85b66fe to efcf8a8 Compare February 3, 2026 17:07
Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
@dikshaa2909 dikshaa2909 force-pushed the add-mit-attribution-no-endorsement branch from 441f6b5 to 3152d25 Compare February 3, 2026 17:32
Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
@dikshaa2909
Copy link
Author

Thanks for the clarification , I’ve updated the rule to follow existing patterns by using {{ }} markers directly in the license text and removed the incorrect required_phrases usage.
I’ve also updated the PR description to follow the project template and addressed the CI failures. Please let me know if anything else needs adjustment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-changes PR needs to be updated with feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ~219 spelling mistakes across documentation and source code comments

2 participants