Fix #4684: Include release field in RPM package version#4700
Open
Jayant-kernel wants to merge 3 commits intoaboutcode-org:developfrom
Open
Fix #4684: Include release field in RPM package version#4700Jayant-kernel wants to merge 3 commits intoaboutcode-org:developfrom
Jayant-kernel wants to merge 3 commits intoaboutcode-org:developfrom
Conversation
Signed-off-by: Jayant <jayantmcom@gmail.com>
8c3b3b9 to
d283393
Compare
Author
|
@pombredanne
Happy to address any concerns if maintainers need the failures investigated further. |
Signed-off-by: Jayant <jayantmcom@gmail.com>
e971555 to
6122595
Compare
Simplified test docstring to be more concise and natural. Signed-off-by: Jayant Saxena <jayantmcom@gmail.com> Signed-off-by: Jayant <jayantmcom@gmail.com>
a0d1214 to
b1b758c
Compare
Author
|
@AyanSinhaMahapatra @pombredanne sir, |
Author
|
@AyanSinhaMahapatra @chinyeungli @pombredanne |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4684
Problem
RPM versions were getting truncated - showing
4.4.20instead of4.4.20-4.el8_6because the release field was being dropped.Solution
Modified
rpm_installed.pyto capture and combine the version, release, and epoch fields:EpochandReleasetagsepoch:version-releaseWhat Changed
Testing
Added regression test that verifies version+release combination:
✅ Passes
Files Changed
src/packagedcode/rpm_installed.py(+25, -2)tests/packagedcode/test_rpm_installed.py(+28)Note: Test data file updates will come in a follow-up PR to keep this easy to review.
Related:
Tasks
Signed-off-by: Jayant jayantmcom@gmail.com