Skip to content

Prevent leaking field validation errors on captcha failure #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keshav-space merged 1 commit into from
Feb 3, 2025
Merged

Prevent leaking field validation errors on captcha failure #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions fedcode/templates/admin_login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,13 @@
{% block content %}

{% if form.errors %}
{% for error in form.errors.values %}
<p>{{ error }}</p>
{% endfor %}
{% if form.errors.captcha %}
{{ form.errors.captcha }}
{% else %}
{% for error in form.errors.values %}
{{ error }}
{% endfor %}
{% endif %}
{% endif %}


Expand Down
10 changes: 7 additions & 3 deletions fedcode/templates/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,13 @@
<div class="notification is-danger">
<button class="delete"></button>
<strong>Error!</strong>
{% for error in form.errors.values %}
{{ error }}
{% endfor %}
{% if form.errors.captcha %}
{{ form.errors.captcha }}
{% else %}
{% for error in form.errors.values %}
{{ error }}
{% endfor %}
{% endif %}
</div>
{% endif %}

Expand Down
10 changes: 7 additions & 3 deletions fedcode/templates/user_sign_up.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,13 @@
<p>Error</p>
</div>
<div class="message-body">
{% for error in form.errors.values %}
{{ error }}
{% endfor %}
{% if form.errors.captcha %}
{{ form.errors.captcha }}
{% else %}
{% for error in form.errors.values %}
{{ error }}
{% endfor %}
{% endif %}
</div>
</article>
</div>
Expand Down