Skip to content

Conversation

@ThoSap
Copy link
Contributor

@ThoSap ThoSap commented Nov 3, 2025

No description provided.

@ThoSap ThoSap requested review from SirCotare and Copilot November 3, 2025 11:14
@ThoSap ThoSap self-assigned this Nov 3, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two new testing annotation utilities: @BlankSource and @NullAndBlankSource for JUnit 5 parameterized tests. These annotations provide convenient sources of blank/empty and null values for testing string validation scenarios.

  • Added @BlankSource annotation that provides various blank string values (empty, whitespace, tabs, newlines)
  • Added @NullAndBlankSource annotation that combines null values with blank string values
  • Both annotations are designed as meta-annotations that can be used on test methods or other annotations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
BlankSource.java New annotation providing blank string test values via @ValueSource
NullAndBlankSource.java New composite annotation combining @NullSource and @BlankSource

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Retention(RetentionPolicy.RUNTIME)
@Documented
@NullSource
@BlankSource
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @BlankSource annotation is referenced before it's imported. Add import it.aboutbits.springboot.testing.valuesource.BlankSource; to the imports section.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad bot

Copy link
Contributor

@SirCotare SirCotare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ThoSap ThoSap merged commit a7be246 into main Nov 3, 2025
1 check passed
@ThoSap ThoSap deleted the add-null-and-blank-source branch November 3, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants