Add configurable unattended reboot orchestration with optional k3s drain hooks#2
Open
Copilot wants to merge 10 commits into
Open
Add configurable unattended reboot orchestration with optional k3s drain hooks#2Copilot wants to merge 10 commits into
Copilot wants to merge 10 commits into
Conversation
Agent-Logs-Url: https://github.com/aboutbits/ansible-base/sessions/8c25a300-3b5f-4ba7-82b6-f752ab3257dd Co-authored-by: alexlanz <3337260+alexlanz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aboutbits/ansible-base/sessions/8c25a300-3b5f-4ba7-82b6-f752ab3257dd Co-authored-by: alexlanz <3337260+alexlanz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aboutbits/ansible-base/sessions/8c25a300-3b5f-4ba7-82b6-f752ab3257dd Co-authored-by: alexlanz <3337260+alexlanz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aboutbits/ansible-base/sessions/8c25a300-3b5f-4ba7-82b6-f752ab3257dd Co-authored-by: alexlanz <3337260+alexlanz@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
alexlanz
May 8, 2026 11:30
View session
Copilot stopped work on behalf of
alexlanz due to an error
May 9, 2026 05:39
Agent-Logs-Url: https://github.com/aboutbits/ansible-base/sessions/ebaa318b-c38a-4c2d-85fd-d64f68ed7044 Co-authored-by: alexlanz <3337260+alexlanz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aboutbits/ansible-base/sessions/ebaa318b-c38a-4c2d-85fd-d64f68ed7044 Co-authored-by: alexlanz <3337260+alexlanz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aboutbits/ansible-base/sessions/ebaa318b-c38a-4c2d-85fd-d64f68ed7044 Co-authored-by: alexlanz <3337260+alexlanz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/aboutbits/ansible-base/sessions/e6b0fb63-6166-4672-bece-4cd44613c276 Co-authored-by: alexlanz <3337260+alexlanz@users.noreply.github.com>
alexlanz
requested review from
ThoSap and
stplasim
and removed request for
alexlanz
ThoSap
approved these changes
May 12, 2026
stplasim
reviewed
May 12, 2026
| when: base_unattended_update_enabled | ||
|
|
||
| - name: Create unattended-upgrades pre-reboot hooks directory | ||
| ansible.builtin.file: |
There was a problem hiding this comment.
This overrides the entire file, right? It also removes all the default settings, such as allowed origins and package blacklists. Is this what we want? Maybe we should check first to see if it would remove something that we still need or want.
https://github.com/mvo5/unattended-upgrades/blob/master/data/50unattended-upgrades.Ubuntu
| mode: '0755' | ||
| content: | | ||
| #!/bin/bash | ||
| set -euo pipefail |
There was a problem hiding this comment.
If I understand this right, the set -euo pipefail and if ! "$hook" are working against each other here, one says fail fast, the other is clearly trying to keep going after a failure.
Currently it would run them all, fail at the end. Is this intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.