ivy.el (ivy-resume): automatically resume to last resumable session#2785
Open
kiennq wants to merge 1 commit intoabo-abo:masterfrom
Open
ivy.el (ivy-resume): automatically resume to last resumable session#2785kiennq wants to merge 1 commit intoabo-abo:masterfrom
kiennq wants to merge 1 commit intoabo-abo:masterfrom
Conversation
basil-conto
reviewed
Jan 12, 2021
Collaborator
basil-conto
left a comment
basil-conto
left a comment
There was a problem hiding this comment.
Apart from a couple of minor nits, LGTM, thanks.
kiennq
force-pushed
the
bug/ivy-resume
branch
from
49ca474 to
1173c5f
Compare
Contributor
Author
|
@basil-conto Is this okay to be merged? |
Collaborator
It looks fine to me, but that's for @abo-abo to decide, sorry. |
Contributor
Author
|
I see, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current when we try to resume to current
ivy-last, sometimes it failed withThe last session isn't compatible with ivy-resume.However, we already have a list of resumable sessions stored in
ivy--sessionsalready. That can be used to automatically determine the session to be resumed from when invoked byivy-resume.In this change:
ivy--sessionsstore the session as a stack, so the last used session will always on topivy-resume, use the top ofivy--sessionsas the desired session.