ivy.el (ivy--update-minibuffer): allow to resumed using stale data f…#2762
Open
kiennq wants to merge 2 commits intoabo-abo:masterfrom
Open
ivy.el (ivy--update-minibuffer): allow to resumed using stale data f…#2762kiennq wants to merge 2 commits intoabo-abo:masterfrom
kiennq wants to merge 2 commits intoabo-abo:masterfrom
Conversation
basil-conto
reviewed
Dec 16, 2020
Collaborator
basil-conto
left a comment
basil-conto
left a comment
There was a problem hiding this comment.
I'm not familiar with this code, but apart from a couple of nits it looks fine to me, thanks.
kiennq
force-pushed
the
feat/resume-stale
branch
from
c67b98a to
844aea6
Compare
kiennq
changed the title
basil-conto
approved these changes
Dec 16, 2020
Contributor
Author
|
@abo-abo Can you help take a look to see if this can be merged? |
…om dynamic collection
kiennq
force-pushed
the
feat/resume-stale
branch
from
844aea6 to
e2e16f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rom dynamic collection.
This change is allow to resume to staled data from dynamic collection.
Of course we can always use
ivy-occurbutivy-occuris taking a whole window + not an obvious choice to go to it after resuming from a dynamic collection (likecounsel-rg).Also,
ivy-occurforcounsel-rgdoesn't work on Windows due to different path separator.This change add new customize value of
ivy-resume-with-staled-dataand allow user to resume with stale data instead.That would save (in most time) one more search and position in search list when resuming.
Solution for #1095 (comment)