Skip to content

fix: fallback to type name in from_exception when exception has no message #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owenpearson merged 1 commit into from
Dec 18, 2025
Merged

fix: fallback to type name in from_exception when exception has no message #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ably/util/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,13 @@ def decode_error_response(response):
def from_exception(e):
if isinstance(e, AblyException):
return e
return AblyException(f"Unexpected exception: {e}", 500, 50000)
exc_type = type(e).__name__
exc_msg = str(e)
if exc_msg:
message = f"{exc_type}: {exc_msg}"
else:
message = exc_type
return AblyException(f"Unexpected exception: {message}", 500, 50000)

@staticmethod
def from_dict(value: dict):
Expand Down