Skip to content

Update error code for invalid credentials in tests #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeskeR merged 1 commit into from
Feb 14, 2025
Merged

Update error code for invalid credentials in tests #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/ably/realtime/realtimeauth_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ async def test_auth_wrong_api_key(self):
ably = await TestApp.get_ably_realtime(key=api_key)
state_change = await ably.connection.once_async(ConnectionState.FAILED)
assert ably.connection.error_reason == state_change.reason
assert state_change.reason.code == 40005
assert state_change.reason.status_code == 400
assert state_change.reason.code == 40101
assert state_change.reason.status_code == 401
await ably.close()

async def test_auth_with_token_string(self):
Expand All @@ -63,8 +63,8 @@ async def test_auth_with_invalid_token_string(self):
invalid_token = "Sdnurv_some_invalid_token_nkds9r7"
ably = await TestApp.get_ably_realtime(token=invalid_token)
state_change = await ably.connection.once_async(ConnectionState.FAILED)
assert state_change.reason.code == 40005
assert state_change.reason.status_code == 400
assert state_change.reason.code == 40101
assert state_change.reason.status_code == 401
await ably.close()

async def test_auth_with_token_details(self):
Expand All @@ -81,8 +81,8 @@ async def test_auth_with_invalid_token_details(self):
invalid_token_details = TokenDetails(token="invalid-token")
ably = await TestApp.get_ably_realtime(token_details=invalid_token_details)
state_change = await ably.connection.once_async(ConnectionState.FAILED)
assert state_change.reason.code == 40005
assert state_change.reason.status_code == 400
assert state_change.reason.code == 40101
assert state_change.reason.status_code == 401
await ably.close()

async def test_auth_with_auth_callback_with_token_request(self):
Expand Down Expand Up @@ -133,8 +133,8 @@ async def callback(params):

ably = await TestApp.get_ably_realtime(auth_callback=callback)
state_change = await ably.connection.once_async(ConnectionState.FAILED)
assert state_change.reason.code == 40005
assert state_change.reason.status_code == 400
assert state_change.reason.code == 40101
assert state_change.reason.status_code == 401
await ably.close()

async def test_auth_with_auth_url_json(self):
Expand Down
8 changes: 4 additions & 4 deletions test/ably/realtime/realtimeconnection_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ async def test_auth_invalid_key(self):
state_change = await ably.connection.once_async()
assert ably.connection.state == ConnectionState.FAILED
assert state_change.reason
assert state_change.reason.code == 40005
assert state_change.reason.status_code == 400
assert state_change.reason.code == 40101
assert state_change.reason.status_code == 401
assert ably.connection.error_reason
assert ably.connection.error_reason.code == 40005
assert ably.connection.error_reason.status_code == 400
assert ably.connection.error_reason.code == 40101
assert ably.connection.error_reason.status_code == 401
await ably.close()

async def test_connection_ping_connected(self):
Expand Down
4 changes: 2 additions & 2 deletions test/ably/realtime/realtimeresume_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ async def test_fatal_resume_error(self):
ably.connection.connection_manager.notify_state(ConnectionState.DISCONNECTED)

state_change = await ably.connection.once_async(ConnectionState.FAILED)
assert state_change.reason.code == 40005
assert state_change.reason.status_code == 400
assert state_change.reason.code == 40101
assert state_change.reason.status_code == 401
await ably.close()

# RTN15c7 - invalid resume response
Expand Down
Loading