feature: Add annotation support for enum configuration #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flrossetto
commented
Dec 2, 2025
flrossetto
commented
- Add new EnumConfig struct with annotation parsing capabilities
- Implement annotation processing for per-enum configuration overrides
- Support annotations like @marshal, @SQL, @Prefix, @nocase, @NoPrefix
- Add example annotation enum with comprehensive test coverage
- Update generator to respect annotation-based configuration
- Maintain backward compatibility with existing enum definitions
- Add new EnumConfig struct with annotation parsing capabilities - Implement annotation processing for per-enum configuration overrides - Support annotations like @marshal, @SQL, @Prefix, @nocase, @NoPrefix - Add example annotation enum with comprehensive test coverage - Update generator to respect annotation-based configuration - Maintain backward compatibility with existing enum definitions
Owner
|
Hey @flrossetto I like the idea of adding per enum configuration, I've just bee too busy to give this a full review. I'll try to get to it over the holiday season! Thanks so much for spending time to improve the project. |
abice
reviewed
Dec 19, 2025
| ) | ||
|
|
||
| // EnumConfigValue holds a configuration value with its validity flag. | ||
| type EnumConfigValue struct { |
Owner
There was a problem hiding this comment.
Instead of using interface here, I'd prefer seeing this as a generic implementation. I don't believe i'm supporting go versions older than 1.18 anymore, so I think it's ok to introduce this as
EnumConfigValue[T enumValue] {
Value T
Valid bool
}
With the enumValue being the interface to constrain it to a string or bool.
Is there something I'm missing that would make that invalid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.