Skip to content

Run Database Migrations#33

Merged
abhibongale merged 1 commit into
mainfrom
phase-1-foundation
May 20, 2026
Merged

Run Database Migrations#33
abhibongale merged 1 commit into
mainfrom
phase-1-foundation

Conversation

@abhibongale
Copy link
Copy Markdown
Owner

@abhibongale abhibongale commented May 20, 2026

  • Runned ironic-dbsync to create schema
  • Ensured migrations run before services start
  • Handled migration failures gracefully
  • Verifed database is properly initialized
  • Maked migrations idempotent (safe to run multiple times)

Closes: #7

Description

Related Issue

Fixes #

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)

Checklist

  • My code follows the style guidelines of this project (black, ruff)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Testing

Unit Tests

pytest tests/unit/ -v

Code Quality

black --check stackbox/ tests/
ruff check stackbox/ tests/
mypy stackbox/core/compose.py

Coverage

pytest --cov=stackbox --cov-report=term-missing

Screenshots (if applicable)

Additional Notes

- Runned ironic-dbsync to create schema
- Ensured migrations run before services start
- Handled migration failures gracefully
- Verifed database is properly initialized
- Maked migrations idempotent (safe to run multiple times)

Closes: #7
Signed-off-by: Abhishek Bongale <abhishekbongale@outlook.com>
@abhibongale abhibongale self-assigned this May 20, 2026
@abhibongale abhibongale added the enhancement New feature or request label May 20, 2026
Copy link
Copy Markdown
Owner Author

@abhibongale abhibongale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhibongale abhibongale merged commit 884e605 into main May 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Database Migrations

1 participant